From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 4/4] package/freescale-imx/firmware-imx: Clean up the image/target semantic
Date: Sat, 11 Jul 2020 22:53:37 +0200 [thread overview]
Message-ID: <20200711225337.579a2569@windsurf.home> (raw)
In-Reply-To: <1594382445-4464-5-git-send-email-stephane.viau@oss.nxp.com>
On Fri, 10 Jul 2020 14:00:45 +0200
Stephane Viau <stephane.viau@oss.nxp.com> wrote:
> The newly introduced BR2_PACKAGE_FIRMWARE_IMX_xxx symbols shall be
> used in lieue of the SoC type when installing images or binaries on
> target.
>
> These new symbols let us define FIRMWARE_IMX_INSTALL_IMAGES_CMDS and
> FIRMWARE_IMX_INSTALL_TARGET_CMDS based on platform needs rather than
> SoC type.
>
> Suggested-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Stephane Viau <stephane.viau@oss.nxp.com>
I've applied, with some changes:
- I dropped the BR2_PACKAGE_FIRMWARE_IMX_NEEDS_DDR_FW conditional, and
instead just use conditions on BR2_PACKAGE_FIRMWARE_IMX_LPDDR4 and
BR2_PACKAGE_FIRMWARE_IMX_DDR4
- I renamed FIRMWARE_IMX_PREPARE_DDR_FW to
FIRMWARE_IMX_INSTALL_IMAGE_DDR_FW, because what it does is really
install the firmware.
- I've used the correct option names after my changes on PATCH 3/4.
- I simplified the VPU installation tweak for i.MX8X.
I've done a few tests, but if you can have a second look at what I
committed, it would be useful.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-07-11 20:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 12:00 [Buildroot] [PATCH v3 0/4] package/freescale-imx: clean-up proposal Stephane Viau
2020-07-10 12:00 ` [Buildroot] [PATCH v3 1/4] package/freescale-imx: Move DDR FW choice down to firmware-imx package Stephane Viau
2020-07-11 20:48 ` Thomas Petazzoni
2020-07-12 6:10 ` Yann E. MORIN
2020-07-12 8:28 ` Thomas Petazzoni
2020-07-10 12:00 ` [Buildroot] [PATCH v3 2/4] package/freescale-imx/firmware-imx: Fix sdma/vpu firmware install path Stephane Viau
2020-07-11 14:11 ` Thomas Petazzoni
2020-07-10 12:00 ` [Buildroot] [PATCH v3 3/4] package/freescale-imx/firmware-imx: Add option for all i.MX FW needs Stephane Viau
2020-07-11 20:51 ` Thomas Petazzoni
2020-07-10 12:00 ` [Buildroot] [PATCH v3 4/4] package/freescale-imx/firmware-imx: Clean up the image/target semantic Stephane Viau
2020-07-11 20:53 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711225337.579a2569@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox