From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/bitwise: new package
Date: Sun, 12 Jul 2020 16:10:29 +0200 [thread overview]
Message-ID: <20200712161029.34a9d83b@windsurf.home> (raw)
In-Reply-To: <20200706093743.2176995-1-rfried.dev@gmail.com>
Shalom Ramon,
On Mon, 6 Jul 2020 12:37:43 +0300
Ramon Fried <rfried.dev@gmail.com> wrote:
> Bitwise is multi base interactive calculator supporting dynamic
> base conversion and bit manipulation.
> It's a handy tool for low level hackers,
> kernel developers and device drivers developers.
>
> Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
I was not totally sure of the value of this for the target system, this
is not normally where you would need a tool like this. But OK, that's a
simple package, so why not. I've applied after doing some changes, see
below.
> diff --git a/package/bitwise/bitwise.hash b/package/bitwise/bitwise.hash
> new file mode 100644
> index 0000000000..b31b640ecd
> --- /dev/null
> +++ b/package/bitwise/bitwise.hash
> @@ -0,0 +1,2 @@
We normally put a comment that says where the hash comes from. When it
was simply calculated locally, we add:
# Locally calculated
so I just did this.
> +sha256 33ce934fb99dadf7652224152cc135a0abf6a211adde53d96e9be7067567749c bitwise-v0.41.tar.gz
> +sha256 3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986 COPYING
> diff --git a/package/bitwise/bitwise.mk b/package/bitwise/bitwise.mk
> new file mode 100644
> index 0000000000..2ef183c1a0
> --- /dev/null
> +++ b/package/bitwise/bitwise.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# bitwise
> +#
> +################################################################################
> +
> +BITWISE_VERSION = 0.41
> +BITWISE_SITE = https://github.com/mellowcandle/bitwise/releases/download/v$(BITWISE_VERSION)
> +BITWISE_SOURCE = bitwise-v$(BITWISE_VERSION).tar.gz
> +BITWISE_DEPENDENCIES = ncurses readline
> +BITWISE_LICENSE = GPL-2.0
Well, this is your project, and your COPYING file says it's under
GPL-3.0, so I changed this value as well.
Applied with those two changes. Toda!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-07-12 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 9:37 [Buildroot] [PATCH v3] package/bitwise: new package Ramon Fried
2020-07-12 14:10 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712161029.34a9d83b@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox