Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/2] configs/rock_pi_4: new defconfig
Date: Sun, 12 Jul 2020 22:29:59 +0200	[thread overview]
Message-ID: <20200712222959.54d8d12c@windsurf.home> (raw)
In-Reply-To: <1593893805-8430-3-git-send-email-sunil@amarulasolutions.com>

On Sun,  5 Jul 2020 01:46:45 +0530
Suniel Mahesh <sunil@amarulasolutions.com> wrote:

> Add initial support for RK3399 based rockpi-4 targets (model A, B, C)
> with below features:
> 
> 	- Custom U-Boot 2020.07-rc4
> 	  https://github.com/amarula/u-boot-amarula.git
> 	  branch rock-pi
> 	- Linux 5.4.46
> 	- GPT partition layout is being used
> 	- Default packages from buildroot
> 
> Signed-off-by: Suniel Mahesh <sunil@amarulasolutions.com>
> ---
> Changes for v3:
> - no changes

Applied to master with similar changes than the n10 defconfig.

Regarding the use of u-boot-rockchip.bin, I think I very much prefer
that there is one partition for each bootloader stage. Having this huge
image u-boot-rockchip.bin, with a huge gap in the middle feels odd, so
I tend to prefer the solution implemented by your patch as it is.

Of course, please send some updates when the ATF support and U-Boot
support is fully merged, so that we can use mainline and tagged releases.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-07-12 20:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04 20:16 [Buildroot] [PATCH v3 0/2] Add support for radxa rk3399 and rk3399pro based targets Suniel Mahesh
2020-07-04 20:16 ` [Buildroot] [PATCH v3 1/2] configs/rock_pi_n10: new defconfig Suniel Mahesh
2020-07-12 20:04   ` Thomas Petazzoni
2020-07-13  6:42     ` Suniel Mahesh
2020-07-04 20:16 ` [Buildroot] [PATCH v3 2/2] configs/rock_pi_4: " Suniel Mahesh
2020-07-06  1:57   ` Tian Yuanhao
2020-07-06  4:37     ` Suniel Mahesh
2020-07-06  8:13       ` Tian Yuanhao
2020-07-06 11:45         ` Suniel Mahesh
2020-07-06 12:21           ` Tian Yuanhao
2020-07-06 12:26             ` Suniel Mahesh
2020-07-12 20:29   ` Thomas Petazzoni [this message]
2020-07-13  6:47     ` Suniel Mahesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200712222959.54d8d12c@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox