Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/gst1-plugins-bayer2rgb-neon: bump to 0.4
Date: Sun, 12 Jul 2020 23:20:01 +0200	[thread overview]
Message-ID: <20200712232001.609f3b61@windsurf.home> (raw)
In-Reply-To: <20200702083619.737-1-eloi.bail@savoirfairelinux.com>

On Thu,  2 Jul 2020 10:36:19 +0200
Eloi Bail <eloi.bail@savoirfairelinux.com> wrote:

> Bump gst1-plugins-bayer2rgb-neon to 0.4.
> 
> Signed-off-by: Eloi Bail <eloi.bail@savoirfairelinux.com>

I've applied, but there's something odd that caught my eye. See below.

> -GST1_PLUGINS_BAYER2RGB_NEON_VERSION = 0.3
> -GST1_PLUGINS_BAYER2RGB_NEON_SOURCE = gst-bayer2rgb-neon-v$(GST1_PLUGINS_BAYER2RGB_NEON_VERSION).tar.bz2
> +GST1_PLUGINS_BAYER2RGB_NEON_VERSION = 0.4
> +GST1_PLUGINS_BAYER2RGB_NEON_SOURCE = gst-bayer2rgb-neon-$(GST1_PLUGINS_BAYER2RGB_NEON_VERSION).tar.bz2

So your change the SOURCE variable to drop the "v", so I wondered why
and looked at https://git.phytec.de/gst-bayer2rgb-neon/. The tag was
v0.3 and the new tag is still v0.4. But the snapshot tarball name
doesn't have the "v", for both the 0.3 and 0.4 versions. But still the
v0.3.tar.gz download that we had until now worked fine. This puzzles me
quite a bit. Especially since the download *without* the v as you're
doing for 0.4 also works.

So I've applied your patch but I'm quite puzzled by this difference
between the tag name and the snapshot tarball name, and how it can work
with v0.3.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-07-12 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  8:36 [Buildroot] [PATCH 1/1] package/gst1-plugins-bayer2rgb-neon: bump to 0.4 Eloi Bail
2020-07-12 21:20 ` Thomas Petazzoni [this message]
2020-07-16 10:19   ` Éloi Bail

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200712232001.609f3b61@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox