Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH RESEND 0/2] Use bzip2 for X11 PFC font compression
Date: Mon, 13 Jul 2020 21:32:25 +0200	[thread overview]
Message-ID: <20200713213225.7e9d3343@windsurf.home> (raw)
In-Reply-To: <20200713184751.23534-1-asierra@xes-inc.com>

Hello Aaron,

Thanks for this work!

On Mon, 13 Jul 2020 13:47:49 -0500
Aaron Sierra <asierra@xes-inc.com> wrote:

> Gzip has been used as the default compressor for PCF fonts, but this
> series changes the default compressor to bzip2 for a few reasons:
> 
> 1. Even with the latest gzip, these seemingly synonymous pipelines
>    produce different output, but this issue does not exist with bzip2:
> 
>   $ cat /path/to/file | gzip > /path/to/file.gz
>   $ gzip < /path/to/file > /path/to/file.gz
> 
> 2. Prior to gzip 1.10, the compression pipeline used with PCF fonts was
>    not reproducible due to the implicit -N/--name injecting a timestamp:
> 
>   * cat /path/to/file | gzip > /path/to/file.gz
> 
> 3. The BR2_USE_WCHAR dependency of the gzip package tarnishes the appeal
>    of using host-gzip to provide reproducible output.

This argument seems pretty weird. The fact that gzip needs
BR2_USE_WCHAR on the target doesn't at all prevent from building
host-gzip. We have plenty of host packages that need wchar packages,
and we simply assume the host system as wide char support available.

So this third argument is a bit "moot", especially since
host-xapp-mkfontscale already has a dependency on host-gzip, which
builds a gzip 1.10, so it shouldn't be affected by the problem you
describe.

So that leaves us with just argument (1), correct ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-07-13 19:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 18:47 [Buildroot] [PATCH RESEND 0/2] Use bzip2 for X11 PFC font compression Aaron Sierra
2020-07-13 18:47 ` [Buildroot] [PATCH RESEND 1/2] package/x11r7/xapp_mkfontscale: support bzip2 Aaron Sierra
2020-07-13 19:33   ` Thomas Petazzoni
2020-07-13 18:47 ` [Buildroot] [PATCH RESEND 2/2] package/x11r7/xfont_font-*: make outputs reproducible Aaron Sierra
2020-07-13 19:32 ` Thomas Petazzoni [this message]
2020-07-13 19:34   ` [Buildroot] [PATCH RESEND 0/2] Use bzip2 for X11 PFC font compression Thomas Petazzoni
2020-07-13 19:55   ` Aaron Sierra
2020-07-13 19:56     ` Thomas Petazzoni
2020-07-14  1:24 ` [Buildroot] [PATCH v2] package/x11r7/xfont_font-*: make outputs reproducible Aaron Sierra
2020-07-14 12:30   ` Thomas Petazzoni
2020-07-21 21:05   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713213225.7e9d3343@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox