From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10
Date: Mon, 13 Jul 2020 23:34:18 +0200 [thread overview]
Message-ID: <20200713233418.4f232caf@windsurf.home> (raw)
In-Reply-To: <20200625005836.2232591-1-urjaman@gmail.com>
Hello Urja,
Thanks for your contribution!
On Thu, 25 Jun 2020 03:58:36 +0300
Urja Rannikko <urjaman@gmail.com> wrote:
> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
>
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.
>
> .../cdrkit/0003-genisoimage-outfile-extern.patch | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch
>
> diff --git a/package/cdrkit/0003-genisoimage-outfile-extern.patch b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> new file mode 100644
> index 0000000000..5a9f0363c9
> --- /dev/null
> +++ b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> @@ -0,0 +1,13 @@
> +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
> +index bbedfb0..82c859b 100644
> +--- a/genisoimage/genisoimage.h
> ++++ b/genisoimage/genisoimage.h
Thanks a lot for your patch! However, we need the cdrkit patch to have
a proper commit title, commit description and Signed-off-by.
See
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for more details.
Could you adjust your patch accordingly ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-07-13 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 0:58 [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10 Urja Rannikko
2020-07-13 18:49 ` Heiko Thiery
2020-07-13 21:34 ` Thomas Petazzoni [this message]
2020-07-19 17:42 ` [Buildroot] [PATCH v2] " Urja Rannikko
2020-07-19 19:42 ` Yann E. MORIN
2020-07-24 11:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713233418.4f232caf@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox