Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Makefile: delete debug libs when debug is not enabled
Date: Tue, 14 Jul 2020 10:13:40 +0200	[thread overview]
Message-ID: <20200714101340.186cbf90@windsurf.home> (raw)
In-Reply-To: <20200714022554.2045-1-danomimanchego123@gmail.com>

On Mon, 13 Jul 2020 22:25:54 -0400
Danomi Manchego <danomimanchego123@gmail.com> wrote:

> +ifneq ($(BR2_ENABLE_DEBUG),y)
> +	rm -rf $(TARGET_DIR)/lib/debug $(TARGET_DIR)/usr/lib/debug
> +endif

The thing is that BR2_ENABLE_DEBUG=y doesn't mean you want debugging
symbols on the target, it means you want debugging symbols in staging.

So, I adjusted this to:

+ifneq ($(BR2_ENABLE_DEBUG):$(BR2_STRIP_strip),y:)
+       rm -rf $(TARGET_DIR)/lib/debug $(TARGET_DIR)/usr/lib/debug
+endif

As BR2_ENABLE_DEBUG=y + BR2_STRIP_strip disabled is the best indication
we have (I believe) to say "I want debugging symbols on the target".

Applied with that change. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-07-14  8:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14  2:25 [Buildroot] [PATCH 1/1] Makefile: delete debug libs when debug is not enabled Danomi Manchego
2020-07-14  8:13 ` Thomas Petazzoni [this message]
2020-07-21 20:50 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714101340.186cbf90@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox