From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 16 Jul 2020 16:07:45 +0200 Subject: [Buildroot] [PATCH] package/freescale-imx/firmware-imx: fix sdma support for imx8m family In-Reply-To: <20200716135250.GA467516@p1g2> References: <20200716130317.135841-1-gary.bisson@boundarydevices.com> <20200716154637.52159ef7@windsurf.home> <20200716135250.GA467516@p1g2> Message-ID: <20200716160745.2c845a4e@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Thu, 16 Jul 2020 15:52:50 +0200 Gary Bisson wrote: > > Thanks for looking into this. Another possible solution if we have more > > of this in the future (we already have it for vpu and sdma) would be to > > drop the NEEDS_XYZ_FW options and instead do this: > > > > config BR2_PACKAGE_FIRMWARE_IMX_VPU_FW_NAME > > string > > default "imx53" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 > > default "imx7d" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M > > default "imx7d" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM > > default "imx7d" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN > > > > and then in the .mk file, we rely on > > BR2_PACKAGE_FIRMWARE_IMX_VPU_FW_NAME being empty or not to decide > > whether the VPU firmware should be installed. And because this variable > > is not just a boolean, it also tells us what is the firmware name. > > Yes it looks like a better option, we could even do the same for VPU > then. > Are we all ok with such approach? I think it doesn't add more lines, and will avoid the calculation of FIRMWARE_IMX_PLATFORM_LOWER. > Note the '*' which makes everything works ;) > That is why imx7 will properly the imx7d binary and the imx27 will copy > the imx27_TO2 one. Ah indeed, and that's another thing we could get rid of with the proposal above, as we would have the exact firmware name. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com