Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/rpi-firmware: bad startup file names
Date: Thu, 16 Jul 2020 23:28:17 +0200	[thread overview]
Message-ID: <20200716232817.753c7b99@gmx.net> (raw)
In-Reply-To: <87sgdrs9r2.fsf@dell.be.48ers.dk>

Hello Peter,

On Thu, 16 Jul 2020 18:30:25 +0200, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "St?phane" == St?phane Veyret <sveyret@gmail.com> writes:  
> 
>  > When booting, a Raspberry Pi will load the appropriate start files,
>  > depending on the provided configuration. For example, if the config.txt
>  > file contains ?gpu_mem=16? the board will automatically load the
>  > cut-down startup files (start_cd.elf and fixup_cd.dat on non-Rpi4).  
> 
>  > Unfortunately, even when the appropriate version is selected in the
>  > configuration menu, if the rpi-firmware makefile takes the good files,
>  > it renames them to non-qualified, i.e. start.elf and fixup.dat. But as
>  > these are not the files searched by the Raspberry Pi, the board will not
>  > start.  
> 
>  > This patch will set the names of the files to load as constant in the
>  > config.txt file. This guarantees that the rpi firmware blobs do not take
>  > any other corner-case decision based on any other as-yet unknown
>  > conditions.  
> 
>  > This eases the maintenance, as only the names of the source files
>  > matter; the destination filenames are constants, and so are the
>  > filenames in config.txt.  
> 
>  > Fixes: #13026  
> 
>  > Signed-off-by: St?phane Veyret <sveyret@gmail.com>  
> 
>  > ---
>  > Changes v2 -> v3:
>  >   - factorization of start file copy, rework on code (suggested by
>  >     Yann E. MORIN).
>  > Changes v1 -> v2:
>  >   - update config.txt instead of keeping firmware name (suggested by
>  >     Yann E. MORIN).  
> 
> Committed to 2020.02.x and 2020.05.x, thanks.
> 

This one needs [1] too...

Regards,
Peter

[1] https://git.buildroot.net/buildroot/commit/?id=59c3426c5197fc2df1c8307543ed54edbb22f595

  reply	other threads:[~2020-07-16 21:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 10:41 [Buildroot] [PATCH v3 1/1] package/rpi-firmware: bad startup file names Stéphane Veyret
2020-06-26 21:15 ` Yann E. MORIN
2020-07-16 16:30 ` Peter Korsgaard
2020-07-16 21:28   ` Peter Seiderer [this message]
2020-07-17  6:54     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716232817.753c7b99@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox