From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/exiv2: fix compiler flags detection
Date: Mon, 20 Jul 2020 18:08:34 +0200 [thread overview]
Message-ID: <20200720180834.25e060bc@windsurf.home> (raw)
In-Reply-To: <20200719161721.GW18825@scaer>
On Sun, 19 Jul 2020 18:17:21 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> You've used TABs in this file that otherwise uses spaces. Hence,
> indentation is off; I've "fixed" that.
Gah, stupid Emacs :-/
> Additionally, the file uses CRLF, so I had to also fix that (not your
> fault, patchowrk is picky about CRLF).
Yes, I knew about CRLF, but I can't do much here, as you say, it's
patchwork that messes up with CRLF line endings.
> Note also that he patch you sent upstream has the same TAB issue,
> causing incorrect rendering of the diff:
> https://github.com/Exiv2/exiv2/pull/1252/commits/4a76388f7f03e8ec73730292aa6866eda83df4e7
It seems like anyway it is not going to be the variant that will be
applied. The project maintainer is looking for help to resolve this
issue more globally, but oh well it's not as if Buildroot wasn't
keeping me busy enough already!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-07-20 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 14:34 [Buildroot] [PATCH] package/exiv2: fix compiler flags detection Thomas Petazzoni
2020-07-19 16:17 ` Yann E. MORIN
2020-07-20 16:08 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720180834.25e060bc@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox