Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] gitlab: generate the gitlab-ci configuration before each build
Date: Mon, 27 Jul 2020 13:52:01 +0200	[thread overview]
Message-ID: <20200727115201.GV19818@scaer> (raw)
In-Reply-To: <20200725213558.1368219-1-romain.naour@gmail.com>

Romain, All,

On 2020-07-25 23:35 +0200, Romain Naour spake thusly:
> Since Gitlab 12.9, Gitlab allow to trigger child pipeline with generated configuration file.
> See: https://gitlab.com/gitlab-org/gitlab/-/issues/35632
> 
> This allow us to stop updating the .gitlab-ci.yml file when a
> new defconfig is added to Buildroot.
> 
> Remove check-gitlab-ci.yml job since it is now uneeded.
> Remove .gitlab-ci.yml make target.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> ---
[--SNIP--]
> diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
> index bde7543c25..ef3edb500d 100644
> --- a/docs/manual/contribute.txt
> +++ b/docs/manual/contribute.txt
> @@ -574,8 +574,7 @@ emulator and provide test case conditions.
>  Beyond creating the test script, there are a couple of additional steps that
>  should be taken once you have your initial test case script. The first is
>  to add yourself to the +DEVELOPERS+ file to be the maintainer of that test
> -case. The second is to update the Gitlab CI yml by executing
> -+make .gitlab-ci.yml+.
> +case. The second is to update the Gitlab CI yml.

There is not even this second step to do at all anymore, now that the
thing is generated in the pipeline. So all we need to document, now is:

    After creating the test script, add yourself to the +DEVELOPERS+ file to
    be the maintainer of that test case.

I've fixed that locally, applied to master and pushed. Thanks.

Regards,
Yann E. MORIN.

>  ==== Debugging a test case
>  
> diff --git a/.gitlab-ci.yml.in b/support/misc/gitlab-ci.yml.in
> similarity index 92%
> rename from .gitlab-ci.yml.in
> rename to support/misc/gitlab-ci.yml.in
> index 1facd2a66f..cf9bf5f9cf 100644
> --- a/.gitlab-ci.yml.in
> +++ b/support/misc/gitlab-ci.yml.in
> @@ -1,8 +1,5 @@
>  # Configuration for Gitlab-CI.
>  # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
> -# The .gitlab-ci.yml file is generated from .gitlab-ci.yml.in.
> -# It needs to be regenerated every time a defconfig is added, using
> -# "make .gitlab-ci.yml".
>  
>  image: buildroot/base:20191027.2027
>  
> @@ -32,13 +29,6 @@ check-flake8:
>      after_script:
>          - wc -l files.processed
>  
> -check-gitlab-ci.yml:
> -    extends: .check_base
> -    script:
> -        - mv .gitlab-ci.yml .gitlab-ci.yml.orig
> -        - make .gitlab-ci.yml
> -        - diff -u .gitlab-ci.yml.orig .gitlab-ci.yml
> -
>  check-package:
>      extends: .check_base
>      script:
> -- 
> 2.25.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-07-27 11:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25 21:35 [Buildroot] [PATCH v2] gitlab: generate the gitlab-ci configuration before each build Romain Naour
2020-07-27 11:52 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727115201.GV19818@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox