From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 10/10] package/cargo-bin: remove and use cargo-bin from rust-bin package
Date: Mon, 27 Jul 2020 13:51:08 +0200 [thread overview]
Message-ID: <20200727135108.3b6b3be1@windsurf.home> (raw)
In-Reply-To: <20200207180829.165689-11-arnout@mind.be>
On Fri, 7 Feb 2020 19:08:29 +0100
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> wrote:
> From: Patrick Havelange <patrick.havelange@essensium.com>
>
> Rust upstream distributes tarballs with separate rust and cargo
> binaries, but also tarballs with everything together. The latter
> contains a bit more than what we need, so the download is slightly
> larger than separate cargo-bin and rust-bin. But it simplifies our life
> if we do the same in rust-bin as in rust (i.e. get both rust and cargo).
>
> Also added hashes for rust-bin powerpc64le, which was missing before.
Actually the powerpc64le hash was not needed, since we don't support
powerpc64le as a host architecture for Rust currently:
config BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
bool
default y if BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> HOST_RUST_BIN_PROVIDES = host-rustc
> -HOST_RUST_BIN_DEPENDENCIES = host-cargo-bin
>
> -HOST_RUST_BIN_SOURCE = rustc-$(RUST_BIN_VERSION)-$(RUSTC_HOST_NAME).tar.xz
> -
> -HOST_RUST_BIN_EXTRA_DOWNLOADS = \
> - rust-std-$(RUST_BIN_VERSION)-$(RUSTC_HOST_NAME).tar.xz
> +HOST_RUST_BIN_SOURCE = rust-$(RUST_BIN_VERSION)-$(RUSTC_HOST_NAME).tar.xz
>
> ifeq ($(BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS),y)
> -HOST_RUST_BIN_EXTRA_DOWNLOADS += rust-std-$(RUST_BIN_VERSION)-$(RUSTC_TARGET_NAME).tar.xz
> +HOST_RUST_BIN_EXTRA_DOWNLOADS = rust-std-$(RUST_BIN_VERSION)-$(RUSTC_TARGET_NAME).tar.xz
I've kept a += here, there was no reason to do this change, and we
prefer assignments in conditions to use += instead of =.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-07-27 11:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 18:08 [Buildroot] [PATCH v3 00/10] Merge rust and cargo Arnout Vandecappelle
2020-02-07 18:08 ` [Buildroot] [PATCH v3 01/10] package/rustc: install cargo config as toolchain post-install hook Arnout Vandecappelle
2020-03-27 10:42 ` David PIERRET
2020-05-18 10:51 ` Patrick Havelange
2020-07-27 11:49 ` Thomas Petazzoni
2020-02-07 18:08 ` [Buildroot] [PATCH v3 02/10] package/rust: build and install cargo Arnout Vandecappelle
2020-02-09 10:21 ` Yann E. MORIN
2020-02-09 16:37 ` Arnout Vandecappelle
2020-03-27 10:44 ` David PIERRET
2020-04-29 13:15 ` Romain Naour
2020-07-27 11:49 ` Thomas Petazzoni
2020-02-07 18:08 ` [Buildroot] [PATCH v3 03/10] package/cargo-bin: install if rust-bin selected Arnout Vandecappelle
2020-03-27 10:47 ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 04/10] package/rust-bin: host variant depends on host-cargo-bin Arnout Vandecappelle
2020-03-27 10:50 ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 05/10] package/rust: drop dependency " Arnout Vandecappelle
2020-03-27 10:51 ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 06/10] package/ripgrep: depends on host-rustc Arnout Vandecappelle
2020-03-27 10:53 ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 07/10] package/cargo: drop package Arnout Vandecappelle
2020-03-27 10:56 ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 08/10] docs/manual: cargo packages depend on host-rustc Arnout Vandecappelle
2020-03-27 10:57 ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 09/10] package/rust: bump to 1.40 Arnout Vandecappelle
2020-03-27 11:02 ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 10/10] package/cargo-bin: remove and use cargo-bin from rust-bin package Arnout Vandecappelle
2020-03-27 11:08 ` David PIERRET
2020-07-27 11:51 ` Thomas Petazzoni [this message]
2020-02-07 21:19 ` [Buildroot] [PATCH v3 00/10] Merge rust and cargo Matthew Weber
2020-07-27 11:48 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727135108.3b6b3be1@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox