Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/cli11: new package
Date: Mon, 27 Jul 2020 21:33:29 +0200	[thread overview]
Message-ID: <20200727193329.GK19818@scaer> (raw)
In-Reply-To: <20200727212345.2d650692@windsurf.home>

Thomas, All,

On 2020-07-27 21:23 +0200, Thomas Petazzoni spake thusly:
> On Mon,  6 Jul 2020 05:17:15 -0600
> Aleksandr Makarov <aleksandr.o.makarov@gmail.com> wrote:
[--SNIP--]
> > +ifeq ($(BR2_PACKAGE_CLI11_SINGLE_FILE),y)
> > +CLI11_CONF_OPTS += -DCLI11_SINGLE_FILE=ON \
> > +                   -DCLI11_INSTALL=OFF
> > +CLI11_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON3),host-python3,host-python)
> > +endif
> 
> Overall, wouldn't it be simpler to simply use the pre-generated single
> header file that the upstream project provides at
> https://github.com/CLIUtils/CLI11/releases ?
> 
> For example
> https://github.com/CLIUtils/CLI11/releases/download/v1.9.1/CLI11.hpp
> for the latest release. Is there any drawback in doing this ?

Yes: the header is not versionned. So if we update, we'll end up with
another CLI11.hpp which content is different.

This will cause issues for users, as they would need to re-download if
they need to support two versions of Buildroot (.g. for an old and a new
project using two different Buildroot version), adn for us, as we could
not host both version in s.b.o.

Of course, we could download it "manually" as a post-doenload hook, and
rename the cached file, but meh... :-/

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-07-27 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 11:17 [Buildroot] [PATCH 1/1] package/cli11: new package Aleksandr Makarov
2020-07-27 19:23 ` Thomas Petazzoni
2020-07-27 19:33   ` Yann E. MORIN [this message]
2020-07-27 20:29     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727193329.GK19818@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox