From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] configs/freescale_imx7ulpevkb: new defconfig
Date: Thu, 6 Aug 2020 22:16:01 +0200 [thread overview]
Message-ID: <20200806221601.718dc67d@windsurf.home> (raw)
In-Reply-To: <b9edfc3c395961381588485123935741b81be22e.camel@oss.nxp.com>
Hello Fabrice,
On Thu, 06 Aug 2020 18:57:28 +0200
Fabrice Goucem <fabrice.goucem@oss.nxp.com> wrote:
> > This is doing two things at once: adding the IMX7ULP support in
> > package/freescale-imx/Config.in (which should come as a separate
> > patch,
> > and before the imx-m4-demos package) and the imx7ulpevkb defconfig
> > addition. Could you split that up ?
>
> Chicken and egg situation...
> Package imx-mcore-demos is needed to introduce support to i.MX7ULP EVK.
> What I can do is remove i.MX7ULP support in the initial imx-mcore-demos
> commit and add it in the i.MX7ULP commit.
There is no chicken and egg problem at all:
- PATCH 1: introduce BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7ULP,
adjusting the BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 definition
along the way.
- PATCH 2: introduce the imx-mcore-demos package
- PATCH 3: adjust the logic in
board/freescale/common/imx/post-image.sh to add the M4 firmware to
the image
- PATCH 4: add the imx7ulpevkb defconfig
> > Are you sure the i.MX7 has a GPU ? According to
> > https://www.nxp.com/products/processors-and-microcontrollers/arm-processors/i-mx-applications-processors/i-mx-7-processors:IMX7-SERIES
> > only the i.MX7 ULP has a GPU, unless I'm misreading this.
>
> You are correct.
> However fixing that (that's in master) would not be part of my patch
> which only targets i.MX7 ULP support.
The current option BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 has a prompt
that says it covers both imx7d and imx7ulp, so it's not totally
incorrect that I.MX7 in general can have a GPU. However, your series
changes this vague IMX7 option by separating the IMX7ULP (which has a
GPU) for the other IMX7 (that don't have a GPU). So it should be part
of the patch adding BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7ULP to
readjust the fact that BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 doesn't
have a GPU.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-08-06 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 12:13 [Buildroot] [PATCH 1/2] package/freescale-imx/imx-m4-demos: new package Fabrice Goucem
2020-07-31 12:13 ` [Buildroot] [PATCH 2/2] configs/freescale_imx7ulpevkb: new defconfig Fabrice Goucem
2020-08-05 20:51 ` Thomas Petazzoni
2020-08-06 16:57 ` Fabrice Goucem
2020-08-06 20:16 ` Thomas Petazzoni [this message]
2020-08-05 20:34 ` [Buildroot] [PATCH 1/2] package/freescale-imx/imx-m4-demos: new package Thomas Petazzoni
2020-08-06 19:29 ` Fabrice Goucem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806221601.718dc67d@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox