Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Dautricourt <olivier.dautricourt@orolia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/gpsd: bump version to 3.21
Date: Tue, 18 Aug 2020 23:13:01 +0200	[thread overview]
Message-ID: <20200818211301.GA51654@orolia.com> (raw)
In-Reply-To: <20200818223041.485653f7@windsurf.home>

Hello Thomas,

The 08/18/2020 22:30, Thomas Petazzoni wrote:
> 
> Hello Olivier,
> 
> On Tue, 18 Aug 2020 19:21:19 +0200
> Olivier Dautricourt <olivier.dautricourt@orolia.com> wrote:
> 
> > > > - removed unnecessary patch
> > > > - removed obsolete gpsd options:
> > > >       GPSD_CONTROLSEND
> > Option was just removed upstream (e720403069dd6ca)
> > Reason given was: "It overlapped RECONFIGURE_ENABLE in strange ways".
> > This was preventing gpsctl to configure receivers, but i guess this
> > option is not relevant anymore.
> >
> > > >       GPSD_RECONFIGURE
> > Replaced with -p (--passive) runtime option.
> > This is to prevent gpsd to auto-configure receivers.
> >
> > > >       GPSD_FIXED_PORT_SPEED
> > This option was already removed in 3.20.
> > It is replaced with -s <speed> runtime option.
> > FIXED_STOP_BITS was also replaced with -f <framing> opt but this was never
> > included in the buildroot configuration anyway.
> 
> Then I think we need Config.in.legacy handling for the removal of those
> 3 options.

So i would add something like that to Config.in.legacy:

config BR2_PACKAGE_GPSD_FIXED_PORT_SPEED
	bool "compile-time fixed port speed removed"
	select BR2_LEGACY
	help
	  The option was replaced by runtime option -f <speed>

But do i have to take action on the package side such as
patching the default gpsd.service file when the above option is selected:

ExecStart=/usr/local/sbin/gpsd -f ${BR2_PACKAGE_GPSD_FIXED_PORT_SPEED_VALUE}

knowing that the service file could be overwritten by local overlays in the build process.


Thanks !

-- 
Olivier Dautricourt

  reply	other threads:[~2020-08-18 21:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 13:23 [Buildroot] [PATCH 1/2] package/gpsd: bump version to 3.21 Olivier Dautricourt
2020-08-17 13:23 ` [Buildroot] [PATCH 2/2] package/gpsd: add GPSD_PYTHON config option Olivier Dautricourt
2020-08-18 14:49 ` [Buildroot] [PATCH 1/2] package/gpsd: bump version to 3.21 Thomas Petazzoni
2020-08-18 17:01   ` Olivier Dautricourt
2020-08-18 17:21   ` Olivier Dautricourt
2020-08-18 20:30     ` Thomas Petazzoni
2020-08-18 21:13       ` Olivier Dautricourt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-08-24  8:04 Olivier Dautricourt
2020-09-16 22:20 ` Titouan Christophe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818211301.GA51654@orolia.com \
    --to=olivier.dautricourt@orolia.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox