Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH
Date: Mon, 24 Aug 2020 10:25:06 +0200	[thread overview]
Message-ID: <20200824082506.GB10811@scaer> (raw)
In-Reply-To: <20200823190650.7bc12a8a@windsurf.home>

Thomas, All,

On 2020-08-23 19:06 +0200, Thomas Petazzoni spake thusly:
> On Sun, 23 Aug 2020 19:03:20 +0200
> Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> 
> > commit: https://git.buildroot.net/buildroot/commit/?id=de9e0f1f00cc4491ef67722b93fb77040ef63043
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> > 
> > hash extension can't be disabled since version 7.4.0 and
> > https://github.com/php/php-src/commit/bf344425812b0f6156d0a8a54ed7bc38054f7636
> > 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > ---
> >  Config.in.legacy       | 6 ++++++
> >  package/php/Config.ext | 7 -------
> >  package/php/php.mk     | 1 -
> >  3 files changed, 6 insertions(+), 8 deletions(-)
> > 
> > diff --git a/Config.in.legacy b/Config.in.legacy
> > index cf7aaf75a5..957cbb8b3c 100644
> > --- a/Config.in.legacy
> > +++ b/Config.in.legacy
> > @@ -146,6 +146,12 @@ endif
> >  
> >  comment "Legacy options removed in 2020.08"
> >  
> > +config BR2_PACKAGE_PHP_EXT_HASH
> > +	bool "php hash extension is mandatory"
> > +	select BR2_LEGACY
> > +	help
> > +	  Since php 7.4.0, hash extension can't be disabled.
> 
> In this sort of situation, we generally don't add any legacy handling.
> Indeed, since the feature is now mandatory... the default behavior will
> always be OK.
> 
> People who could be annoyed are people who had this feature disabled...
> which is now always enabled. But the legacy handling will anyway not
> help those people.

Damn. indeed... I'll push a commit to drop it.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-08-24  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-23 17:03 [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH Yann E. MORIN
2020-08-23 17:06 ` Thomas Petazzoni
2020-08-24  8:25   ` Yann E. MORIN [this message]
2020-08-24  8:33     ` Yann E. MORIN
2020-08-24 13:12       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824082506.GB10811@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox