From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/openfpgaloader: needs gcc >= 4.9
Date: Mon, 24 Aug 2020 10:59:41 +0200 [thread overview]
Message-ID: <20200824085941.GE10811@scaer> (raw)
In-Reply-To: <20200820204158.1237689-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2020-08-20 22:41 +0200, Fabrice Fontaine spake thusly:
> openfpgaloader needs C++11 as specified in CMakeLists.txt:
> set(CMAKE_CXX_STANDARD 11)
>
> The build on gcc 4.8 fails on:
>
> /home/buildroot/autobuild/instance-1/output-1/build/openfpgaloader-849e5751e06d4d00f323205d5f02ee01f9f59a61/src/spiFlash.cpp: In member function 'void SPIFlash::jtag_write_read(uint8_t, uint8_t*, uint8_t*, uint16_t)':
> /home/buildroot/autobuild/instance-1/output-1/build/openfpgaloader-849e5751e06d4d00f323205d5f02ee01f9f59a61/src/spiFlash.cpp:92:43: error: variable-sized object 'jtx' may not be initialized
> uint8_t jtx[xfer_len] = {reverseByte(cmd)};
> ^
>
> Fixes:
> - http://autobuild.buildroot.org/results/f3f3cc216ae42bb8a8925b0df7c1a3cc79b027d7
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
We now have a version that has this fix (as well as others), so this
patch is no longer needed. Thanks for prompting the update! :-)
Regards,
Yann E. MORIN.
> ---
> package/openfpgaloader/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/openfpgaloader/Config.in b/package/openfpgaloader/Config.in
> index 9835b84b64..493fa09c84 100644
> --- a/package/openfpgaloader/Config.in
> +++ b/package/openfpgaloader/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_OPENFPGALOADER
> depends on BR2_PACKAGE_HAS_UDEV
> depends on BR2_INSTALL_LIBSTDCPP # libftdipp1
> depends on BR2_USE_WCHAR # libftdipp1
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11
> select BR2_PACKAGE_ARGP_STANDALONE \
> if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL # argp
> select BR2_PACKAGE_LIBFTDI1
> @@ -13,6 +14,7 @@ config BR2_PACKAGE_OPENFPGALOADER
>
> https://github.com/trabucayre/openFPGALoader/
>
> -comment "openfpgaloader needs udev, a toolchain w/ threads, wchar, C++"
> +comment "openfpgaloader needs udev, a toolchain w/ threads, wchar, C++, gcc >= 4.9"
> depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
> - !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV
> + !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> --
> 2.27.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-08-24 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 20:41 [Buildroot] [PATCH 1/1] package/openfpgaloader: needs gcc >= 4.9 Fabrice Fontaine
2020-08-23 20:01 ` Yann E. MORIN
2020-08-23 20:32 ` Yann E. MORIN
2020-08-23 21:24 ` Yann E. MORIN
2020-08-24 6:24 ` Gwenhael Goavec-Merou
2020-08-24 8:59 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824085941.GE10811@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox