Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/iputils: bump version to 20200821
Date: Mon, 24 Aug 2020 22:41:33 +0200	[thread overview]
Message-ID: <20200824224133.63ade6fe@windsurf.home> (raw)
In-Reply-To: <20200824164042.10778-1-petr.vorel@gmail.com>

On Mon, 24 Aug 2020 18:40:42 +0200
Petr Vorel <petr.vorel@gmail.com> wrote:

> Remove patch from this version.
> 
> Remove USE_CRYPTO related config (configuration was removed in this
> release).
> 
> tftpd is not built by default since this release, thus explicitly enable it.
> 
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>

I have applied to next, but... I have some second thoughts.

> -ifeq ($(BR2_PACKAGE_NETTLE),y)
> -IPUTILS_CONF_OPTS += -DUSE_CRYPTO=nettle
> -IPUTILS_DEPENDENCIES += nettle
> -else ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
> -IPUTILS_CONF_OPTS += -DUSE_CRYPTO=gcrypt
> -IPUTILS_DEPENDENCIES += libgcrypt
> -else ifeq ($(BR2_PACKAGE_OPENSSL),y)
> -IPUTILS_CONF_OPTS += -DUSE_CRYPTO=openssl
> -IPUTILS_DEPENDENCIES += openssl
> -else
> -IPUTILS_CONF_OPTS += -DUSE_CRYPTO=kernel
> -endif

So you no longer have any optional dependency on a crypto provider, i.e
there is nothing that guarantees that openssl will be built before
iputils if openssl is available, for example.

Is that really what you want ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-08-24 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 16:40 [Buildroot] [PATCH 1/1] package/iputils: bump version to 20200821 Petr Vorel
2020-08-24 20:41 ` Thomas Petazzoni [this message]
2020-08-25  6:38   ` Petr Vorel
2020-08-25  7:16     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824224133.63ade6fe@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox