Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/iptraf-ng: bump to version 1.2.1
Date: Tue, 25 Aug 2020 10:09:56 +0200	[thread overview]
Message-ID: <20200825100956.730252a5@windsurf.home> (raw)
In-Reply-To: <1597833691-18154-1-git-send-email-jugurtha.belkalem@smile.fr>

Hello Jugurtha,

On Wed, 19 Aug 2020 12:41:31 +0200
Jugurtha BELKALEM <jugurtha.belkalem@smile.fr> wrote:

> PTraf-ng is a console-based network monitoring program for Linux that
> displays information about IP traffic. It returns such information as:
> 
> - Current TCP connections
> - UDP, ICMP, OSPF, and other types of IP packets
> - Packet and byte counts on TCP connections
> - IP, TCP, UDP, ICMP, non-IP, and other packet and byte counts
> - TCP/UDP counts by ports
> - Packet counts by packet sizes
> - Packet and byte counts by IP address
> - Interface activity
> - Flag statuses on TCP packets
> - LAN station statistics
> 
> V1.2.1 fixed multiple issues in V1.1.4 like :
> - Introduce packet capturing abstraction: add recvmmsg(),
>   TPACKET_V2 and TPACKET_V3 to capture in multigigabit speeds.
> - Handling mlock() failures and carry on execution (without
>   crashing iptraf-ng).
> - Properly account non-IP packets.
> - Show dropped packet count.
> 
> Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>

I've applied to next, with a few changes, see below.

> -IPTRAF_NG_MAKE_ENV = \
> -	NCURSES_LDFLAGS="-lpanel -lncurses"

I had to keep NCURSES_LDFLAGS, otherwise the iptraf build system calls
the host ncurses5-config (or similar) script, and gets linker flags
suitable for the host ncurses, and not the target ncurses. In my case,
it caused the build to fail.

> +# HOME should be overwritten, otherwise it falls on the value of
> +# the cross compiling machine.
> +define IPTRAF_NG_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
> +			   HOME=$(TARGET_DIR)/usr install

Instead of overriding HOME, I've done it like this:

		prefix=/usr DESTDIR=$(TARGET_DIR)

which looks a bit more "standard".

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-08-25  8:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 10:41 [Buildroot] [PATCH 1/1] package/iptraf-ng: bump to version 1.2.1 Jugurtha BELKALEM
2020-08-25  8:09 ` Thomas Petazzoni [this message]
2020-08-26 21:27 ` Thomas Petazzoni
2020-08-27  8:10   ` Jugurtha BELKALEM
  -- strict thread matches above, loose matches on Subject: below --
2020-08-17 15:08 Jugurtha BELKALEM
2020-08-18 21:22 ` Thomas Petazzoni
2020-08-14 14:39 Jugurtha BELKALEM
2020-08-14 19:35 ` Thomas Petazzoni
2020-08-14 14:38 Jugurtha BELKALEM

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825100956.730252a5@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox