From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/assimp: workaround m68k build issues
Date: Tue, 25 Aug 2020 23:26:31 +0200 [thread overview]
Message-ID: <20200825212631.GH2246@scaer> (raw)
In-Reply-To: <20200825210143.293881-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2020-08-25 23:01 +0200, Thomas Petazzoni spake thusly:
> On m68k coldfire, we already pass -mxgot, but since the bump to assimp
> 5.0.1, this is no longer sufficient, and we have failures such as:
>
> /tmp/ccqmJLil.s: Assembler messages:
> /tmp/ccqmJLil.s:307948: Error: value -43420 out of range
> /tmp/ccqmJLil.s:307985: Error: value -38606 out of range
> /tmp/ccqmJLil.s:308010: Error: value -38626 out of range
> /tmp/ccqmJLil.s:308056: Error: value -33280 out of range
>
> Since these issues only arise when building with -O2, let's disable
> the optimization for this package on m68k. The very relative relevance
> of assimp on m68k coldfire makes the research of a better solution not
> really useful (for the record, assimp is a "library to import various
> well-known 3D model formats in a uniform manner").
>
> Fixes:
>
> http://autobuild.buildroot.net/results/a7d4fb2653b0f1be4d036ee46a44e72da0ed4376/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Both applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/assimp/assimp.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/assimp/assimp.mk b/package/assimp/assimp.mk
> index 4aeb2963a9..e8620c859a 100644
> --- a/package/assimp/assimp.mk
> +++ b/package/assimp/assimp.mk
> @@ -10,9 +10,11 @@ ASSIMP_LICENSE = BSD-3-Clause
> ASSIMP_LICENSE_FILES = LICENSE
> ASSIMP_INSTALL_STAGING = YES
>
> -# relocation truncated to fit: R_68K_GOT16O
> +# relocation truncated to fit: R_68K_GOT16O. We also need to disable
> +# optimizations to not run into "Error: value -43420 out of range"
> +# assembler issues.
> ifeq ($(BR2_m68k),y)
> -ASSIMP_CXXFLAGS += -mxgot
> +ASSIMP_CXXFLAGS += -mxgot -O0
> endif
>
> # workaround SuperH compiler failure when static linking (i.e -fPIC is
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-08-25 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 21:01 [Buildroot] [PATCH 1/2] package/assimp: workaround m68k build issues Thomas Petazzoni
2020-08-25 21:01 ` [Buildroot] [PATCH 2/2] package/assimp: also build with -mxgot on mips64(el) Thomas Petazzoni
2020-08-28 17:27 ` Peter Korsgaard
2020-08-25 21:26 ` Yann E. MORIN [this message]
2020-08-28 17:27 ` [Buildroot] [PATCH 1/2] package/assimp: workaround m68k build issues Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825212631.GH2246@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox