From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/mosquitto: bump to v1.6.11
Date: Thu, 27 Aug 2020 23:32:46 +0200 [thread overview]
Message-ID: <20200827233246.1964df63@windsurf.home> (raw)
In-Reply-To: <20200819120506.137013-1-titouan.christophe@railnova.eu>
On Wed, 19 Aug 2020 14:05:05 +0200
Titouan Christophe <titouan.christophe@railnova.eu> wrote:
> diff --git a/package/mosquitto/Config.in b/package/mosquitto/Config.in
> index b4effa36be..078d6ad151 100644
> --- a/package/mosquitto/Config.in
> +++ b/package/mosquitto/Config.in
> @@ -1,3 +1,8 @@
> +config BR2_PACKAGE_MOSQUITTO_WITH_THREADING
> + bool
> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_setname_np
> + default y if BR2_TOOLCHAIN_HAS_THREADS
This looks awkward. Why are you not just doing:
-ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),y)
MOSQUITTO_MAKE_OPTS += WITH_THREADING=yes
else
MOSQUITTO_MAKE_OPTS += WITH_THREADING=no
in the .mk file ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-08-27 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:05 [Buildroot] [PATCH v2 1/2] package/mosquitto: bump to v1.6.11 Titouan Christophe
2020-08-19 12:05 ` [Buildroot] [PATCH v2 2/2] package/{collectd, domoticz, shairport-sync}: fix mosquitto dependencies Titouan Christophe
2020-08-27 21:36 ` Thomas Petazzoni
2020-08-27 21:32 ` Thomas Petazzoni [this message]
2020-08-28 9:12 ` [Buildroot] [PATCH v2 1/2] package/mosquitto: bump to v1.6.11 Titouan Christophe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827233246.1964df63@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox