From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pipewire: bump to version 0.3.6
Date: Thu, 27 Aug 2020 23:48:30 +0200 [thread overview]
Message-ID: <20200827234830.534955b4@windsurf.home> (raw)
In-Reply-To: <20200706010444.537633-1-james.hilliard1@gmail.com>
On Sun, 5 Jul 2020 19:04:44 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Add pipewire optional dependencies/configurations.
>
> Remove BR2_PACKAGE_PIPEWIRE_GSTREAMER config option and enable
> automatically based on dependencies to avoid recursive dependency
> error caused by the gobject-introspection python3 dependency.
Could you give more details about this recursive dependency ?
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Config.in.legacy | 10 +++
> package/pipewire/Config.in | 27 +-------
> package/pipewire/pipewire.hash | 6 +-
> package/pipewire/pipewire.mk | 114 +++++++++++++++++++++++++++------
> 4 files changed, 110 insertions(+), 47 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 7a5435188b..4541acc979 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,16 @@ endif
>
> comment "Legacy options removed in 2020.08"
>
> +config BR2_PACKAGE_PIPEWIRE_GSTREAMER
> + bool "pipewire gstreamer option removed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_GOBJECT_INTROSPECTION
> + select BR2_PACKAGE_GSTREAMER1
> + select BR2_PACKAGE_GST1_PLUGINS_BASE
But isn't that going to cause that circular dependency you're trying to
prevent, since you're selecting BR2_PACKAGE_GOBJECT_INTROSPECTION here ?
Or maybe what you're talking about is not a Kconfig recursive
dependency, but a makefile circular dependency ? But in the later case,
I'm not sure how dropping the Config.in option helps.
Could you clarify ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-08-27 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 1:04 [Buildroot] [PATCH 1/1] package/pipewire: bump to version 0.3.6 James Hilliard
2020-08-27 21:48 ` Thomas Petazzoni [this message]
2020-10-16 5:50 ` James Hilliard
2021-04-25 19:52 ` Yann E. MORIN
2021-04-25 20:02 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827234830.534955b4@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox