From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/rtty: fix build with mbedtls but without zlib
Date: Sun, 30 Aug 2020 22:31:54 +0200 [thread overview]
Message-ID: <20200830223154.3bb3ed2f@windsurf.home> (raw)
In-Reply-To: <CAPi7W836LNsN20-Zu=WW_Z9Zp_p2DFx41TnH6cUxDrVqjmaJ3g@mail.gmail.com>
On Sun, 30 Aug 2020 22:11:43 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Is there a reason why zlib is necessary for mbedtls support ?
> zlib is not mandatory with mbedtls, only optional, however as mbedtls
> does not provide a pkg-config file, we assume that if zlib is
> available, we must link with it to avoid a build failure when linking
> statically with a zlib-enabled mbedtls.
> This change was pushed upstream with
> https://github.com/zhaojh329/rtty/commit/7b8efe11dbafce97971dc130bf6cc1756f34ce07.
> However, we missed that this change will raise a build failure if
> ZLIB_LIBRARIES is used when zlib is not found.
It should be noted that the compression support in mbedtls is only
enabled if BR2_PACKAGE_MBEDTLS_COMPRESSION=y.
So you can have a situation where mbedtls is enabled, zlib is enabled,
but mbedtls is not using zlib. Your change will needlessly link rtty
with zlib in such a situation.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-08-30 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 19:20 [Buildroot] [PATCH 1/1] package/rtty: fix build with mbedtls but without zlib Fabrice Fontaine
2020-08-30 20:02 ` Thomas Petazzoni
2020-08-30 20:11 ` Fabrice Fontaine
2020-08-30 20:31 ` Thomas Petazzoni [this message]
2020-08-30 20:39 ` Fabrice Fontaine
2020-08-30 20:55 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830223154.3bb3ed2f@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox