From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Mon, 31 Aug 2020 14:43:50 +0200 Subject: [Buildroot] [PATCH] support/misc/gitlab-ci.yml.in: include Branches workflow In-Reply-To: <20200830155953.1650346-1-arnout@mind.be> References: <20200830155953.1650346-1-arnout@mind.be> Message-ID: <20200831124350.GP14354@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, +Romain and +Jugurtha, as we've had some discussions on that topic publicly and privately before. On 2020-08-30 17:59 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly: > Recently, gitlab-ci has gained a lot more flexibility in when pipelines > are created. As a side-effect of this, double pipelines may be created > when a `when` clause is used in some job. Avoid this by adding a > workflow that launches it only on branches. See [1] and [2]. > > Note that in reality, the duplicate pipelines only occur for merge > requests. Since we don't have merge requests, we don't have this > problem. Howver, gitlab also displays an annoying error message on the > pipeline page [3], and it sends an error mail to the triggerer (i.e., > Arnout), so it's still useful to do this. > > [1] https://docs.gitlab.com/ee/ci/yaml/README.html#prevent-duplicate-pipelines > [2] https://docs.gitlab.com/ee/ci/yaml/README.html#workflowrules-templates > [3] https://gitlab.com/buildroot.org/buildroot/-/pipelines/183589361/builds > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) > --- > I'd like to get this one in master, because the e-mails are annoying me > :-) I'd like to suggest an alternative: move all the conditions into the generating script, now that we do have a script that generates the pipeline description. Having the conditions in the script will help handle such cases, by only ever emitting those jobs we actually want to run. This would allow for more flexibility than the limited micro-language used by gitlab-ci.yml. Also, this will allow us to not care about the evolutions of that micro- language. To that effect, I already started workign on that two weeks ago, and I have omething that works as before (even better I think): https://git.buildroot.org/~ymorin/git/buildroot/log/?h=yem/gitlab-ci-cond I just need to cleanup that last commit (and remember why I started doing it. meh...). I hope I'll be able to send it tonight. Regards, Yann E. MORIN. > --- > support/misc/gitlab-ci.yml.in | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/support/misc/gitlab-ci.yml.in b/support/misc/gitlab-ci.yml.in > index dddebf09e9..8a031898ef 100644 > --- a/support/misc/gitlab-ci.yml.in > +++ b/support/misc/gitlab-ci.yml.in > @@ -1,6 +1,9 @@ > # Configuration for Gitlab-CI. > # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines > > +include: > + - template: 'Workflows/Branch-Pipelines.gitlab-ci.yml' > + > image: buildroot/base:20200814.2228 > > .check_base: > -- > 2.26.2 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'