[Buildroot] [PATCH 1/1] package/pigpio: add sysv and systemd init scripts

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Grzegorz,

Sorry for the long delay in not getting back to you. A few comments
below.

On Mon, 11 Nov 2019 15:05:34 +0000
Grzegorz Blach <grzegorz@blach.pl> wrote:

> diff --git a/package/pigpio/S50pigpio b/package/pigpio/S50pigpio
> new file mode 100644
> index 0000000000..7b2e979600
> --- /dev/null
> +++ b/package/pigpio/S50pigpio
> @@ -0,0 +1,40 @@
> +#!/bin/sh
> +#
> +# Starts pigpio daemon.
> +#

Could you use package/busybox/S01syslogd as a template for this init
script, and model yours to be as similar as possible ?

> +
> +# Allow a few customizations from a config file
> +test -r /etc/default/pigpio && . /etc/default/pigpio
> +
> +start() {
> +	printf "Starting pigpio daemon: "
> +	umask 077

Why do you need this umask ?

> +	pigpiod $PIGPIOD_ARGS

Could you use start-stop-daemon for starting the daemon?

Other than these comments, the whole thing looks pretty good. If you
respin soon, I promise to apply quickly!

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com