Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/2] support/scripts/pycompile: add --verbose option
Date: Sun, 13 Sep 2020 11:03:40 +0200	[thread overview]
Message-ID: <20200913090340.GM10548@scaer> (raw)
In-Reply-To: <20200910083252.7102-3-robin.jarry@6wind.com>

Robin, All,

On 2020-09-10 10:32 +0200, Robin Jarry spake thusly:
> Add a new option that prints the (runtime) path of compiled .py files
> when VERBOSE=1 is set.
> 
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/python/python.mk     |  1 +
>  package/python3/python3.mk   |  1 +
>  support/scripts/pycompile.py | 11 +++++++++--
>  3 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/package/python/python.mk b/package/python/python.mk
> index 3fe5ecd00462..4bff5f0c7c66 100644
> --- a/package/python/python.mk
> +++ b/package/python/python.mk
> @@ -263,6 +263,7 @@ define PYTHON_CREATE_PYC_FILES
>  	$(HOST_DIR)/bin/python$(PYTHON_VERSION_MAJOR) \
>  		$(TOPDIR)/support/scripts/pycompile.py \
>  		$(if $(BR2_REPRODUCIBLE),--force) \
> +		$(if $(VERBOSE),--verbose) \
>  		--strip-root $(TARGET_DIR) \
>  		$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)
>  endef
> diff --git a/package/python3/python3.mk b/package/python3/python3.mk
> index 4c8a12c7a3ad..52c548accc9b 100644
> --- a/package/python3/python3.mk
> +++ b/package/python3/python3.mk
> @@ -280,6 +280,7 @@ define PYTHON3_CREATE_PYC_FILES
>  	$(HOST_DIR)/bin/python$(PYTHON3_VERSION_MAJOR) \
>  		$(TOPDIR)/support/scripts/pycompile.py \
>  		$(if $(BR2_REPRODUCIBLE),--force) \
> +		$(if $(VERBOSE),--verbose) \
>  		--strip-root $(TARGET_DIR) \
>  		$(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)
>  endef
> diff --git a/support/scripts/pycompile.py b/support/scripts/pycompile.py
> index 04193f4a02c2..55c09fe688d6 100644
> --- a/support/scripts/pycompile.py
> +++ b/support/scripts/pycompile.py
> @@ -31,7 +31,7 @@ else:
>      PYC_HEADER_ARGS += (0,)  # zero hash, we use timestamp invalidation
>  
>  
> -def compile_one(host_path, strip_root=None, force=False):
> +def compile_one(host_path, strip_root=None, force=False, verbose=False):
>      """
>      Compile a .py file into a .pyc file located next to it.
>  
> @@ -42,6 +42,8 @@ def compile_one(host_path, strip_root=None, force=False):
>          files.
>      :arg force:
>          Recompile even if already up-to-date.
> +    :arg verbose:
> +        Print compiled file paths.
>      """
>      if os.path.islink(host_path) or not os.path.isfile(host_path):
>          return  # only compile real files
> @@ -69,6 +71,9 @@ def compile_one(host_path, strip_root=None, force=False):
>      else:
>          runtime_path = host_path
>  
> +    if verbose:
> +        print("  PYC  {}".format(runtime_path))
> +
>      # will raise an error if the file cannot be compiled
>      py_compile.compile(host_path, cfile=host_path + "c",
>                         dfile=runtime_path, doraise=True)
> @@ -95,6 +100,8 @@ def main():
>                          """)
>      parser.add_argument("--force", action="store_true",
>                          help="Force compilation even if already compiled")
> +    parser.add_argument("--verbose", action="store_true",
> +                        help="Print compiled files")
>  
>      args = parser.parse_args()
>  
> @@ -105,7 +112,7 @@ def main():
>              for parent, _, files in os.walk(d):
>                  for f in files:
>                      compile_one(os.path.join(parent, f), args.strip_root,
> -                                args.force)
> +                                args.force, args.verbose)
>  
>      except Exception as e:
>          print("error: {}".format(e))
> -- 
> 2.28.0
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-09-13  9:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 11:29 [Buildroot] [PATCH] pycompile: fix .pyc original source file paths Julien Floret
2020-09-04 21:26 ` Yann E. MORIN
2020-09-04 21:32   ` Yann E. MORIN
2020-09-08  8:10 ` [Buildroot] [PATCH v2 0/4] pycompile: fix .pyc source paths + improvements Robin Jarry
2020-09-08  8:10   ` [Buildroot] [PATCH v2 1/4] pycompile: add main entry point Robin Jarry
2020-09-08  8:10   ` [Buildroot] [PATCH v2 2/4] pycompile: sort imports Robin Jarry
2020-09-08  8:10   ` [Buildroot] [PATCH v2 3/4] pycompile: fix .pyc original source file paths Robin Jarry
2020-09-09 20:34     ` Yann E. MORIN
2020-09-10  7:29       ` Robin Jarry
2020-09-08  8:10   ` [Buildroot] [PATCH v2 4/4] pycompile: add --verbose option Robin Jarry
2020-09-09 20:47     ` Yann E. MORIN
2020-09-09 19:53   ` [Buildroot] [PATCH v2 0/4] pycompile: fix .pyc source paths + improvements Yann E. MORIN
2020-09-10  7:45 ` [Buildroot] [PATCH v3 0/2] " Robin Jarry
2020-09-10  7:45   ` [Buildroot] [PATCH v3 1/2] support/scripts/pycompile: fix .pyc original source file paths Robin Jarry
2020-09-10  7:53     ` Robin Jarry
2020-09-10  7:45   ` [Buildroot] [PATCH v3 2/2] support/scripts/pycompile: add --verbose option Robin Jarry
2020-09-10  8:32 ` [Buildroot] [PATCH v4 0/2] pycompile: fix .pyc source paths + improvements Robin Jarry
2020-09-10  8:32   ` [Buildroot] [PATCH v4 1/2] support/scripts/pycompile: fix .pyc original source file paths Robin Jarry
2020-09-11 21:15     ` Yann E. MORIN
2020-09-12 11:44       ` Robin Jarry
2020-09-13  8:10         ` Yann E. MORIN
2020-09-13  9:03     ` Yann E. MORIN
2020-09-14  7:33       ` Robin Jarry
2020-09-15 18:46     ` Peter Korsgaard
2020-09-10  8:32   ` [Buildroot] [PATCH v4 2/2] support/scripts/pycompile: add --verbose option Robin Jarry
2020-09-13  9:03     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200913090340.GM10548@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox