From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Nosthoff Date: Tue, 15 Sep 2020 18:11:07 +0200 Subject: [Buildroot] [PATCH] package/grpc: fix build on ubuntu gcc 4.8 Message-ID: <20200915161107.1826-1-buildroot@heine.tech> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net gcc 4.8 on ubuntu 14.04 does some broken optimization at link-time which causes grpc to create a grpc_cpp_plugin which quits because of a failing assertion. The created plugin is itself used during compilation which lets the build fail. With the added -Wl,--no-as-needed flag the LTO is disabled and grpc compiles successfully. fixes: - http://autobuild.buildroot.net/results/b554f6f2fb66892273f7520ad6e36923557b229e - http://autobuild.buildroot.net/results/3ebb2880b9b3fd5154979016391dde897e2c039c - http://autobuild.buildroot.net/results/c2078e821e0728fe980be2c849c25d82e791a4c2 Signed-off-by: Michael Nosthoff --- package/grpc/grpc.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/package/grpc/grpc.mk b/package/grpc/grpc.mk index 2114f98e40..4db309d4e9 100644 --- a/package/grpc/grpc.mk +++ b/package/grpc/grpc.mk @@ -72,5 +72,12 @@ HOST_GRPC_CONF_OPTS = \ -DgRPC_ZLIB_PROVIDER=package \ -DgRPC_ABSL_PROVIDER=package +#With gcc 4.8 (at least on ubuntu) there is a bug in LTO which breaks the linkage of +#the grpc_cpp_plugin with libprotobuf and pthread. This additional flag fixes this. +ifeq ($(BR2_HOST_GCC_AT_LEAST_4_9),) +HOST_GRPC_CONF_OPTS += \ + -DCMAKE_EXE_LINKER_FLAGS="$(HOST_LDFLAGS) -Wl,--no-as-needed" +endif + $(eval $(cmake-package)) $(eval $(host-cmake-package)) -- 2.25.1