From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
Date: Wed, 16 Sep 2020 16:57:03 +0200 [thread overview]
Message-ID: <20200916165703.266d2cb8@windsurf.hq.k.grp> (raw)
In-Reply-To: <20200916135834.400-1-mvalabdas@distech-controls.com>
Hello Miken,
Thanks for your contribution!
On Wed, 16 Sep 2020 09:58:34 -0400
Miken Valabdas via buildroot <buildroot@busybox.net> wrote:
> Signed-off-by: Miken Valabdas <mvalabdas@distech-controls.com>
> ---
> package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/18xx-ti-utils/18xx-ti-utils.mk b/package/18xx-ti-utils/18xx-ti-utils.mk
> index d1f0388c3a..41ce8ab973 100644
> --- a/package/18xx-ti-utils/18xx-ti-utils.mk
> +++ b/package/18xx-ti-utils/18xx-ti-utils.mk
> @@ -21,6 +21,11 @@ define 18XX_TI_UTILS_BUILD_CMDS
> NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \
> CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
> $(18XX_TI_UTILS_BUILD_TARGET)
> +
> + $(TARGET_MAKE_ENV) CROSS_COMPILE=$(TARGET_CROSS) \
> + NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D)/wlconf \
> + CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
> + $(18XX_TI_UTILS_BUILD_TARGET)
So this is going to build another tool, but you haven't changed the
18XX_TI_UTILS_INSTALL_TARGET_CMDS to also install it. So how is this
tool going to be practically useful ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-16 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 13:58 [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf Miken Valabdas
2020-09-16 14:57 ` Thomas Petazzoni [this message]
2020-09-16 16:14 ` Valabdas, Miken
2020-09-16 16:28 ` Thomas Petazzoni
2020-09-16 18:52 ` Valabdas, Miken
-- strict thread matches above, loose matches on Subject: below --
2020-09-16 20:35 Miken Valabdas
2020-09-16 21:01 Miken Valabdas
2020-09-17 20:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916165703.266d2cb8@windsurf.hq.k.grp \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox