From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] package/pkg-meson.mk: fix generation of pkg_config_static prop
Date: Wed, 16 Sep 2020 18:34:04 +0200 [thread overview]
Message-ID: <20200916183404.57c5ba0d@gmx.net> (raw)
In-Reply-To: <20200915232732.33a65e66@gmx.net>
Hello Norbert,
second sight, two nitpicks below...
On Tue, 15 Sep 2020 23:27:32 +0200, Peter Seiderer <ps.report@gmx.net> wrote:
> Hello Norbert,
>
> On Tue, 15 Sep 2020 12:05:43 +0200, Norbert Lange <nolange79@gmail.com> wrote:
>
> > fixes following in the generated file:
s/cross-complation.conf/cross-compilation.conf/
> > pkg_config_static = '$(if $(BR2_STATIC_LIBS),true,false)'
Maybe a short sentence about only the 'host/etc/meson/cross-compilation.conf'
(unused internally by buildroot) is affected, the per-package one (used by
buildroot) are correct...
Bug introduced by (wrong) cut and paste from the per-package lines (where the
double $$ is needed)...
Regards,
Peter
> >
> > Signed-off-by: Norbert Lange <nolange79@gmail.com>
> > ---
> > v1->v2:
> > - truly fix the issue, missed one double $
> > ---
> > package/pkg-meson.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> > index c3fe6df5d0..3a34ba703b 100644
> > --- a/package/pkg-meson.mk
> > +++ b/package/pkg-meson.mk
> > @@ -195,7 +195,7 @@ define PKG_MESON_INSTALL_CROSS_CONF
> > -e "s%@TARGET_CXXFLAGS@%$(call make-sq-comma-list,$(TARGET_CXXFLAGS))@PKG_TARGET_CFLAGS@%g" \
> > -e 's%@HOST_DIR@%$(HOST_DIR)%g' \
> > -e 's%@STAGING_DIR@%$(STAGING_DIR)%g' \
> > - -e 's%@STATIC@%$$(if $$(BR2_STATIC_LIBS),true,false)%g' \
> > + -e 's%@STATIC@%$(if $(BR2_STATIC_LIBS),true,false)%g' \
> > $(HOST_MESON_PKGDIR)/cross-compilation.conf.in \
> > > $(HOST_DIR)/etc/meson/cross-compilation.conf.in
> > sed -e 's%@PKG_TARGET_CFLAGS@%%g' \
>
> Reviewed-by: Peter Seiderer <ps.report@gmx.net>
>
> Regards,
> Peter
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2020-09-16 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:05 [Buildroot] [PATCH v2 1/3] package/pkg-meson.mk: fix generation of pkg_config_static prop Norbert Lange
2020-09-15 10:05 ` [Buildroot] [PATCH v2 2/3] package/meson: use specific BR variables for cross-compilation.conf Norbert Lange
2020-09-15 14:05 ` Nicolas Cavallari
2020-09-15 15:46 ` Norbert Lange
2020-09-15 20:50 ` Thomas Petazzoni
2020-09-16 7:42 ` Nicolas Cavallari
2020-09-15 10:05 ` [Buildroot] [PATCH v2 3/3] package/pkg-meson: move crosscompilation support out of package Norbert Lange
2020-09-15 10:24 ` Norbert Lange
2020-09-15 21:27 ` [Buildroot] [PATCH v2 1/3] package/pkg-meson.mk: fix generation of pkg_config_static prop Peter Seiderer
2020-09-16 16:34 ` Peter Seiderer [this message]
2020-09-27 7:34 ` Yann E. MORIN
2020-10-02 8:48 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916183404.57c5ba0d@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox