[Buildroot] [PATCH 1/3 v4] package/qt5/qt5webengine: fix ffmpeg/codec/alsa option handling for latest

[Yann E. MORIN <yann.morin.1998@free.fr>]

Thomas, All,

On 2020-09-17 14:55 +0200, Thomas Petazzoni spake thusly:
> On Wed, 16 Sep 2020 23:11:32 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
> > index 9101f35937..5df6942977 100644
> > --- a/package/qt5/qt5webengine/qt5webengine.mk
> > +++ b/package/qt5/qt5webengine/qt5webengine.mk
> > @@ -29,16 +29,16 @@ endif
> >  
> >  QT5WEBENGINE_DEPENDENCIES += host-libpng host-libnss libnss
> >  
> > -QT5WEBENGINE_CONF_OPTS += WEBENGINE_CONFIG+=use_system_ffmpeg
> > +QT5WEBENGINE_CONF_OPTS = -webengine-ffmpeg
> >  
> >  ifeq ($(BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS),y)
> > -QT5WEBENGINE_CONF_OPTS += WEBENGINE_CONFIG+=use_proprietary_codecs
> > +QT5WEBENGINE_CONF_OPTS += -webengine-proprietary-codecs
> >  endif
> >  
> >  ifeq ($(BR2_PACKAGE_QT5WEBENGINE_ALSA),y)
> >  QT5WEBENGINE_DEPENDENCIES += alsa-lib
> >  else
> > -QT5WEBENGINE_CONF_OPTS += QT_CONFIG-=alsa
> > +QT5WEBENGINE_CONF_OPTS += -no-webengine-alsa
> >  endif
> 
> In the original patch, there was a "--" that was added to separate
> these webengine options from the main options. You have not kept that.
> Are you sure this is OK ?

I am not sure, hence I said in the cover-letter "Note: this is not even
build-tested; it's just a refresh-n-respin."

I'll do a test-build tonight (I did not have spare CPU cycles yesterday,
but tonight I should have some.)

However, none of the qmake-package we have use that '--'.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'