From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/quagga: fix build with gcc 10
Date: Tue, 22 Sep 2020 21:28:54 +0200 [thread overview]
Message-ID: <20200922212854.60f042e9@windsurf> (raw)
In-Reply-To: <20200921213030.57054-1-fontaine.fabrice@gmail.com>
On Mon, 21 Sep 2020 23:30:30 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> + struct ethaddr {
> + u_char octet[ETHER_ADDR_LEN];
> +-} __packed;
I think the intentation was to use the packed gcc attribute, and
perhaps in the past there was a __packed defined to
__attribute__((packed)) or something like that. When this define went
away, __packed became the name of a variable :)
That being said, I'm not sure the packed attribute makes anything
special on a structure that has a single member, so I've applied. We'll
also see what upstream says.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-22 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 21:30 [Buildroot] [PATCH 1/1] package/quagga: fix build with gcc 10 Fabrice Fontaine
2020-09-22 19:28 ` Thomas Petazzoni [this message]
2020-09-29 18:54 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2021-03-06 15:56 Fabrice Fontaine
2021-03-06 19:37 ` Peter Korsgaard
2021-03-16 22:20 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922212854.60f042e9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox