Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/python-m2crypto: add package
Date: Tue, 22 Sep 2020 22:26:15 +0200	[thread overview]
Message-ID: <20200922222615.797ea14d@windsurf> (raw)
In-Reply-To: <20200918151852.1148219-1-gustavo@gsthnz.com>

Hello,

On Fri, 18 Sep 2020 12:18:51 -0300
Gustavo Heinz <gustavo@gsthnz.com> wrote:

> Signed-off-by: Gustavo Heinz <gustavo@gsthnz.com>

Thanks for your contribution. I have applied, with just a few tweaks.

> diff --git a/package/python-m2crypto/Config.in b/package/python-m2crypto/Config.in
> new file mode 100644
> index 0000000000..385a16cac6
> --- /dev/null
> +++ b/package/python-m2crypto/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PYTHON_M2CRYPTO
> +	bool "python-m2crypto"
> +	select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON # runtime
> +	select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3 # runtime
> +	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
> +	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
> +    select BR2_PACKAGE_PYTHON_TYPING if BR2_PACKAGE_PYTHON # runtime

There was an indentation issue here, and you forgot to select
BR2_PACKAGE_OPENSSL: it is a build dependency, it must be selected.

> +PYTHON_M2CRYPTO_VERSION = 0.36.0
> +PYTHON_M2CRYPTO_SOURCE = M2Crypto-$(PYTHON_M2CRYPTO_VERSION).tar.gz
> +PYTHON_M2CRYPTO_SITE = https://files.pythonhosted.org/packages/ff/df/84609ed874b5e6fcd3061a517bf4b6e4d0301f553baf9fa37bef2b509797
> +PYTHON_M2CRYPTO_SETUP_TYPE = setuptools
> +PYTHON_M2CRYPTO_LICENSE = MIT
> +PYTHON_M2CRYPTO_LICENSE_FILES = LICENCE
> +PYTHON_M2CRYPTO_DEPENDENCIES = openssl host-swig
> +PYTHON_M2CRYPTO_BUILD_OPTS = "--openssl=$(TARGET_DIR)/usr"

No need for the double quotes, but more importantly, you should not use
TARGET_DIR here, but STAGING_DIR.

I fixed that up when applying.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2020-09-22 20:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 15:18 [Buildroot] [PATCH] package/python-m2crypto: add package Gustavo Heinz
2020-09-22 20:26 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922222615.797ea14d@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox