From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/zstd: avoid compilation during host-zstd install step
Date: Mon, 28 Sep 2020 22:06:16 +0200 [thread overview]
Message-ID: <20200928200616.GO11621@scaer> (raw)
In-Reply-To: <20200928114228.23637-1-patrickdepinguin@gmail.com>
Thomas, All,
On 2020-09-28 13:42 +0200, Thomas De Schampheleire spake thusly:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> The host-zstd-build step was not actually compiling the library:
>
> make[1]: Entering directory '/buildroot/output/build/host-zstd-1.4.5/lib'
> make[1]: Nothing to be done for 'default'.
> make[1]: Leaving directory '/buildroot/output/build/host-zstd-1.4.5/lib'
>
> and the actual compilation was part of the install step.
> This is not how other Buildroot packages work.
>
> Make sure to specify which library targets we want instead. The total amount
> of compiled files does not change with this patch.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/zstd/zstd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk
> index e2ba12b058..35002da332 100644
> --- a/package/zstd/zstd.mk
> +++ b/package/zstd/zstd.mk
> @@ -71,7 +71,7 @@ endef
> # note: no 'HAVE_...' options for host library build only
> define HOST_ZSTD_BUILD_CMDS
> $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
> - -C $(@D)/lib
> + -C $(@D)/lib libzstd.a libzstd
> $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
> -C $(@D) zstd
> endef
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-09-28 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 11:42 [Buildroot] [PATCH 1/2] package/zstd: avoid compilation during host-zstd install step Thomas De Schampheleire
2020-09-28 11:42 ` [Buildroot] [PATCH 2/2] package/zstd: link programs dynamically with libzstd to save space Thomas De Schampheleire
2020-09-28 19:40 ` Yann E. MORIN
2020-09-28 20:22 ` Thomas De Schampheleire
2020-09-28 19:47 ` Yann E. MORIN
2020-09-28 20:31 ` Thomas De Schampheleire
2020-09-28 20:06 ` Yann E. MORIN [this message]
2020-10-02 8:56 ` [Buildroot] [PATCH 1/2] package/zstd: avoid compilation during host-zstd install step Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928200616.GO11621@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox