From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/misc/gitlab-ci.yml.in: include Branches workflow
Date: Tue, 6 Oct 2020 22:42:17 +0200 [thread overview]
Message-ID: <20201006204217.GS11621@scaer> (raw)
In-Reply-To: <20200830155953.1650346-1-arnout@mind.be>
Arnout, All,
On 2020-08-30 17:59 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Recently, gitlab-ci has gained a lot more flexibility in when pipelines
> are created. As a side-effect of this, double pipelines may be created
> when a `when` clause is used in some job. Avoid this by adding a
> workflow that launches it only on branches. See [1] and [2].
>
> Note that in reality, the duplicate pipelines only occur for merge
> requests. Since we don't have merge requests, we don't have this
> problem. Howver, gitlab also displays an annoying error message on the
> pipeline page [3], and it sends an error mail to the triggerer (i.e.,
> Arnout), so it's still useful to do this.
>
> [1] https://docs.gitlab.com/ee/ci/yaml/README.html#prevent-duplicate-pipelines
> [2] https://docs.gitlab.com/ee/ci/yaml/README.html#workflowrules-templates
> [3] https://gitlab.com/buildroot.org/buildroot/-/pipelines/183589361/builds
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
We've no merged a better script that contains all the logic about
generating the child pipeline, so I believe this patch of yours is no
longer needed.
Regards,
Yann E. MORIN.
> ---
> I'd like to get this one in master, because the e-mails are annoying me
> :-)
> ---
> support/misc/gitlab-ci.yml.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/support/misc/gitlab-ci.yml.in b/support/misc/gitlab-ci.yml.in
> index dddebf09e9..8a031898ef 100644
> --- a/support/misc/gitlab-ci.yml.in
> +++ b/support/misc/gitlab-ci.yml.in
> @@ -1,6 +1,9 @@
> # Configuration for Gitlab-CI.
> # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
>
> +include:
> + - template: 'Workflows/Branch-Pipelines.gitlab-ci.yml'
> +
> image: buildroot/base:20200814.2228
>
> .check_base:
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-10-06 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 15:59 [Buildroot] [PATCH] support/misc/gitlab-ci.yml.in: include Branches workflow Arnout Vandecappelle
2020-08-31 12:43 ` Yann E. MORIN
2020-08-31 12:58 ` Arnout Vandecappelle
2020-08-31 19:52 ` Yann E. MORIN
2020-09-01 6:52 ` Arnout Vandecappelle
2020-08-31 21:49 ` Yann E. MORIN
2020-10-06 20:42 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006204217.GS11621@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox