Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] tpm2-tss: bump version to 3.0.1
Date: Wed, 14 Oct 2020 19:17:54 +0200	[thread overview]
Message-ID: <20201014191754.4ca8cc54@windsurf> (raw)
In-Reply-To: <LTX1nraBUAtkxzJfofN3gcjMI1lgPwo4mbFffGKs5sSFz7uttVsIIataPlRjU4fZ-AerudU8-aQ_sURQ5zYspa10BKG6raTbq7Vhpr2RHH4=@protonmail.com>

Hello Yair,

Thanks for your patch.

On Wed, 14 Oct 2020 15:02:17 +0000
Yair Ben-Avraham via buildroot <buildroot@busybox.net> wrote:

> - 0001-Temporary-fix-for-build-without-C.patch, AC_PROG_CXX line
>   number changed.
> - Makefile-fuzz-generated.am now in size zero.
> - json-c, libcurl: new dependencies since tpm2-tss version 2.4.0
> 
> Signed-off-by: Yair Ben-Avraham <yairba@protonmail.com>

Your patch unfortunately does not apply:

$ git pwam 1382206
Applying patch #1382206 using "git am -s"
Description: [v3,1/1] tpm2-tss: bump version to 3.0.1
Applying: tpm2-tss: bump version to 3.0.1
error: patch failed: package/tpm2-tss/0001-Temporary-fix-for-build-without-C.patch:23
error: package/tpm2-tss/0001-Temporary-fix-for-build-without-C.patch: patch does not apply
Patch failed at 0001 tpm2-tss: bump version to 3.0.1
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
'git am' failed with exit status 128


In addition, the dependencies on json-c and libcurl are not mandatory,
they are only needed if FAPI is enabled. It is the case by default, but
it's a new feature since tpm2-tss, and I suppose it would make sense to
not enable it by default.

Can we make that a sub-option of tpm2-tss ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-10-14 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 15:02 [Buildroot] [PATCH v3 1/1] tpm2-tss: bump version to 3.0.1 Yair Ben-Avraham
2020-10-14 17:17 ` Thomas Petazzoni [this message]
2020-10-14 17:53 ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014191754.4ca8cc54@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox