From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/uboot-tools: create /var/lock directory for fw_printenv
Date: Wed, 14 Oct 2020 23:55:31 +0200 [thread overview]
Message-ID: <20201014235531.301aa821@windsurf> (raw)
In-Reply-To: <20201004125538.15161-1-aleontiev@elvees.com>
Hello Anton,
Thanks for your patch, I'm adding Norbert in Cc. See below for some comments.
On Sun, 4 Oct 2020 15:55:38 +0300
Anton Leontiev <aleontiev@elvees.com> wrote:
> fw_setenv/fw_printenv create lock-files in /var/lock. If this directory
> doesn't exist tools fail with following error:
>
> Error opening lock file /var/lock/fw_printenv.lock
>
> Signed-off-by: Anton Leontiev <aleontiev@elvees.com>
> ---
> package/uboot-tools/uboot-tools.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
> index a06c25998f..578702f04e 100644
> --- a/package/uboot-tools/uboot-tools.mk
> +++ b/package/uboot-tools/uboot-tools.mk
> @@ -65,6 +65,7 @@ ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV),y)
> define UBOOT_TOOLS_INSTALL_FWPRINTENV
> $(INSTALL) -m 0755 -D $(@D)/tools/env/fw_printenv $(TARGET_DIR)/usr/sbin/fw_printenv
> ln -sf fw_printenv $(TARGET_DIR)/usr/sbin/fw_setenv
> + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/lock
Unfortunately, this cannot be the correct solution: the
skeleton-init-sysv package already creates /var/lock, as a symlink to
/tmp, so your patch would clash with that. So I suppose you have a
systemd init?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-10-14 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 12:55 [Buildroot] [PATCH] package/uboot-tools: create /var/lock directory for fw_printenv Anton Leontiev
2020-10-14 21:55 ` Thomas Petazzoni [this message]
2020-10-15 12:42 ` Norbert Lange
2020-10-15 13:46 ` Michael Nosthoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014235531.301aa821@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox