From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] package/libtalloc: new package
Date: Fri, 16 Oct 2020 12:03:05 +0200 [thread overview]
Message-ID: <20201016120305.23b2c455@windsurf> (raw)
In-Reply-To: <CAH3uZAwsvcv5kNFCi_fHgoszzbvKGbh52OeX1eqPbWEpfzYoVg@mail.gmail.com>
Hello David,
On Fri, 16 Oct 2020 08:25:26 +0200
david gouarin <dgouarin@gmail.com> wrote:
> I agree, HOST_DIR is completely wrong here, I totally missed that, and I
> admit I still have difficulties formatting my patches, mainly because I
> have to work in an isolated network :)
Ah, indeed, that may be not the most efficient way of working :/
> I have however sent a new revision for both freeradius and libtalloc as a
> series using git send-email as described in the documentation, I don't
> understand what is wrong ?
They are not numbered: you probably used "git format-patch -N", but you
shouldn't use the -N option in this case.
For patches sent to Buildroot, we want them numbered, so they clearly
appear as a series and we understand that they depend on each other.
For patches to Buildroot packages (i.e patches in package/foo/*.patch),
we want them *NOT* numbered, as otherwise the 2/3 or 5/6 numbering very
quickly gets out of date when adding/removing patches, and this
numbering is already sufficiently explicit by the name of the patches
(0001-something.patch, 0002-something-else.patch).
Perhaps this is what caused the confusion ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-10-16 10:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:37 [Buildroot] [PATCH 1/2] package/libtalloc: new package David GOUARIN
2020-10-13 14:37 ` [Buildroot] [PATCH 2/2] package/freeradius-server: " David GOUARIN
2020-10-13 19:51 ` [Buildroot] [PATCH v2 3/3] " David GOUARIN
2020-10-14 17:02 ` [Buildroot] [PATCH v3] " David GOUARIN
2020-10-14 19:26 ` Thomas Petazzoni
2020-10-15 20:06 ` [Buildroot] [PATCH v4] package/libtalloc: " David GOUARIN
2020-10-15 20:06 ` [Buildroot] [PATCH v4] package/freeradius-server: " David GOUARIN
2020-10-15 20:16 ` [Buildroot] [PATCH v4] package/libtalloc: " Thomas Petazzoni
2020-10-16 6:25 ` david gouarin
2020-10-16 10:03 ` Thomas Petazzoni [this message]
2020-10-19 20:00 ` [Buildroot] [PATCH v5 1/2] " David GOUARIN
2020-10-19 20:00 ` [Buildroot] [PATCH v5 2/2] package/freeradius-server: " David GOUARIN
2020-10-13 14:50 ` [Buildroot] [PATCH 1/2] package/libtalloc: " Matthew Weber
2020-10-13 19:50 ` [Buildroot] [PATCH v2 2/3] " David GOUARIN
2020-10-14 19:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016120305.23b2c455@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox