From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/rpi-userland: build on arm64
Date: Sat, 17 Oct 2020 10:25:25 +0200 [thread overview]
Message-ID: <20201017082525.GF3466@scaer> (raw)
In-Reply-To: <20201017011356.50029-1-aman@tmm1.net>
Aman, All,
Thanks fior this patch. However, I have some comments about it, see
below...
On 2020-10-16 18:13 -0700, Aman Karmani spake thusly:
> Parts of the userland (such as `vcgencmd`) are now usable on aarch64
This has already been proposed a few times already (review all the
messages in those threads):
http://lists.busybox.net/pipermail/buildroot/2020-August/289559.html
http://lists.busybox.net/pipermail/buildroot/2020-January/271577.html
There, it was pointed out that the set of libraries instaleld on AArch64
is different from AArch32, and most notably "no libegl, libgles,
libopenmax, libopenvg" are built and installed.
This means that rpi-userland couldn't be an EGL or GLES or OPENMAX
provider when building for AArch64.
Has that situation improved now?
Regards,
Yann E. MORIN.
> Signed-off-by: Aman Karmani <aman@tmm1.net>
> ---
> package/rpi-userland/Config.in | 4 ++--
> package/rpi-userland/rpi-userland.mk | 6 ++++++
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
> index 342faf26e3..81f3588822 100644
> --- a/package/rpi-userland/Config.in
> +++ b/package/rpi-userland/Config.in
> @@ -1,6 +1,6 @@
> config BR2_PACKAGE_RPI_USERLAND
> bool "rpi-userland"
> - depends on BR2_arm
> + depends on BR2_arm || BR2_aarch64
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on !BR2_STATIC_LIBS
> @@ -40,6 +40,6 @@ config BR2_PACKAGE_RPI_USERLAND_HELLO
> endif
>
> comment "rpi-userland needs a toolchain w/ C++, threads, dynamic library"
> - depends on BR2_arm
> + depends on BR2_arm || BR2_aarch64
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
> BR2_STATIC_LIBS
> diff --git a/package/rpi-userland/rpi-userland.mk b/package/rpi-userland/rpi-userland.mk
> index 4cfd5cb832..97270f2eb4 100644
> --- a/package/rpi-userland/rpi-userland.mk
> +++ b/package/rpi-userland/rpi-userland.mk
> @@ -13,6 +13,12 @@ RPI_USERLAND_CONF_OPTS = -DVMCS_INSTALL_PREFIX=/usr
>
> RPI_USERLAND_PROVIDES = libegl libgles libopenmax libopenvg
>
> +ifeq ($(BR2_aarch64),y)
> +
> +RPI_USERLAND_CONF_OPTS += -DARM64=ON
> +
> +endif
> +
> ifeq ($(BR2_PACKAGE_RPI_USERLAND_HELLO),y)
>
> RPI_USERLAND_CONF_OPTS += -DALL_APPS=ON
> --
> 2.28.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-10-17 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 1:13 [Buildroot] [PATCH 1/1] package/rpi-userland: build on arm64 Aman Karmani
2020-10-17 8:25 ` Yann E. MORIN [this message]
2020-10-17 8:32 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201017082525.GF3466@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox