From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 31 Oct 2020 21:42:11 +0100 Subject: [Buildroot] [PATCH 1/1] package/pax-utils: needs wchar In-Reply-To: <20201031150836.100678-1-fontaine.fabrice@gmail.com> References: <20201031150836.100678-1-fontaine.fabrice@gmail.com> Message-ID: <20201031214211.69a71de5@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Sat, 31 Oct 2020 16:08:36 +0100 Fabrice Fontaine wrote: > pax-utils uses asprintf and so needs wchar since version 1.2.4 and > https://gitweb.gentoo.org/proj/pax-utils.git/commit/?id=9c0ec154d782795daa3b7d2ae273bbda2b36ae83 In fact, it seems like the build problem comes from gnulib, which is bundled in pax-utils. Usage of wctomb() was recently added in gnulib as of commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c. And it seems like there is code to not use wctomb() when wchar support is not available, but that logic doesn't seem to work. I don't really care about pax-utils being not available with wchar disabled, but since gnulib is also used in lots of other projects, I'm fearing that we might see this issue elsewhere. Could you check if the pax-utils copy of gnulib lib/vasnprintf.c includes commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c and report a bug to upstream gnulib ? In the mean time, I have applied your patch, with an extended commit log. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com