Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/opencv: drop package
Date: Sun, 1 Nov 2020 10:04:46 +0100	[thread overview]
Message-ID: <20201101100446.52130bb6@windsurf> (raw)
In-Reply-To: <20201018143200.1250673-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sun, 18 Oct 2020 16:32:00 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> opencv 2.x has seen no release since July 2018 and all buildroot
> packages are already compatible with opencv3 so drop it to ease the
> addition of opencv4 which is not fully backward compatible with opencv3
> as "a lot of C API from OpenCV 1.x has been removed.":
> https://opencv.org/opencv-4-0.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Thanks, I have applied this patch.

> +config BR2_PACKAGE_OPENCV
> +	bool "opencv package was removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_OPENCV3 if BR2_TOOLCHAIN_HAS_ATOMIC && \
> +		!BR2_STATIC_LIBS

I've just dropped this select. opencv3 is not really a drop-in
replacement for opencv, this it felt a bit "weird" to have this being
done automatically. Better have the user take care of this IMO.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2020-11-01  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-18 14:32 [Buildroot] [PATCH 1/1] package/opencv: drop package Fabrice Fontaine
2020-10-18 19:40 ` Yann E. MORIN
2020-11-01  9:04 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201101100446.52130bb6@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox