From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 2/2] package/rhash: add host variant
Date: Sat, 7 Nov 2020 14:10:13 +0100 [thread overview]
Message-ID: <20201107141013.6c742223@windsurf.home> (raw)
In-Reply-To: <20201106202632.2424688-2-bernd.kuhls@t-online.de>
On Fri, 6 Nov 2020 21:26:32 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> + --extra-ldflags="$(HOST_LDFLAGS) -L $(HOST_DIR)/lib -Wl,-rpath,$(HOST_DIR)/lib" \
Well, HOST_LDFLAGS precisely contains
-L$(HOST_DIR)/lib -Wl,-rpath,$(HOST_DIR)/lib
So this feels a bit redundant with what you're doing. Am I missing
something ?
> $(eval $(generic-package))
> +$(eval $(host-autotools-package))
If the target variant if a generic-package, the host variant should
also be a host-generic-package.
Also, in general we don't really like to have "orphan" host packages.
Shouldn't this host package be added together with the support for sha3
hashes ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-11-07 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 20:26 [Buildroot] [PATCH/next 1/2] package/rhash: bump version to 1.4.0 Bernd Kuhls
2020-11-06 20:26 ` [Buildroot] [PATCH/next 2/2] package/rhash: add host variant Bernd Kuhls
2020-11-07 13:10 ` Thomas Petazzoni [this message]
2020-11-07 13:07 ` [Buildroot] [PATCH/next 1/2] package/rhash: bump version to 1.4.0 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107141013.6c742223@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox