Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency
Date: Tue, 10 Nov 2020 22:50:28 +0100	[thread overview]
Message-ID: <20201110225028.259a7d76@gmx.net> (raw)
In-Reply-To: <20201110090204.1581432-1-aperez@igalia.com>

Hello Adrian,

On Tue, 10 Nov 2020 11:02:04 +0200, Adrian Perez de Castro <aperez@igalia.com> wrote:

> WPE WebKit 2.30.0 added an USE_SYSTEMD buil option, which needs to
> be set to avoid CMake from trying to use systemd unconditionally.
>
> Based on a similar patch for package/webkitgtk by Peter Seiderer.
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
>  package/wpewebkit/wpewebkit.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 6233505ca7..6f83775e96 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -63,6 +63,13 @@ else
>  WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
>  endif
>
> +ifeq ($(BR2_INIT_SYSTEMD),y)
> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=ON
> +WPEWEBKIT_DEPENDENCIES += systemd
> +else
> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=OFF
> +endif
> +
>  # JIT is not supported for MIPS r6, but the WebKit build system does not
>  # have a check for these processors. The same goes for ARMv5 and ARMv6.
>  # Disable JIT forcibly here and use the CLoop interpreter instead.

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Note: the status for this patch in patchwork is 'Superseded' [1] (by mistake?)...

Regards,
Peter

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20201110090204.1581432-1-aperez at igalia.com/

  reply	other threads:[~2020-11-10 21:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  9:02 [Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency Adrian Perez de Castro
2020-11-10 21:50 ` Peter Seiderer [this message]
2020-11-10 22:19   ` Peter Korsgaard
2020-11-11  8:20     ` Adrian Perez de Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110225028.259a7d76@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox