From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Perez de Castro Date: Wed, 11 Nov 2020 10:20:29 +0200 Subject: [Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency In-Reply-To: <87blg4onw1.fsf@dell.be.48ers.dk> References: <20201110090204.1581432-1-aperez@igalia.com> <20201110225028.259a7d76@gmx.net> <87blg4onw1.fsf@dell.be.48ers.dk> Message-ID: <20201111102029.GC634430@momiji> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 10 Nov 2020 23:19:58 +0100 Peter Korsgaard wrote: > >>>>> "Peter" == Peter Seiderer writes: > > > Hello Adrian, > > On Tue, 10 Nov 2020 11:02:04 +0200, Adrian Perez de Castro wrote: > > >> WPE WebKit 2.30.0 added an USE_SYSTEMD buil option, which needs to > >> be set to avoid CMake from trying to use systemd unconditionally. > >> > >> Based on a similar patch for package/webkitgtk by Peter Seiderer. > >> > >> Signed-off-by: Adrian Perez de Castro > >> --- > >> package/wpewebkit/wpewebkit.mk | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk > >> index 6233505ca7..6f83775e96 100644 > >> --- a/package/wpewebkit/wpewebkit.mk > >> +++ b/package/wpewebkit/wpewebkit.mk > >> @@ -63,6 +63,13 @@ else > >> WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF > >> endif > >> > >> +ifeq ($(BR2_INIT_SYSTEMD),y) > >> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=ON > >> +WPEWEBKIT_DEPENDENCIES += systemd > >> +else > >> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=OFF > >> +endif > >> + > >> # JIT is not supported for MIPS r6, but the WebKit build system does not > >> # have a check for these processors. The same goes for ARMv5 and ARMv6. > >> # Disable JIT forcibly here and use the CLoop interpreter instead. > > > Reviewed-by: Peter Seiderer > > Committed, thanks. > > > Note: the status for this patch in patchwork is 'Superseded' [1] (by mistake?)... > > I got confused with webkitgtk/wpewebkit and thought it was identical to > your patch, sorry. No worries, it could happen to anyone. I can see how it's easy to mix both wpewebkit and webkitgtk, specially when there are patches that we need for both ^_^ Cheers, -Adri?n -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available URL: