From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/linux-backports: use buildroot host flex and bison
Date: Wed, 11 Nov 2020 22:35:05 +0100 [thread overview]
Message-ID: <20201111213505.GA28486@pevik> (raw)
In-Reply-To: <20201111162208.362275-1-ju.o@free.fr>
Hi Julien,
thanks for working on linux-backports package!
> Upstream backports package does not define the LEX/YACC Makefile
> variables, contrary to the Kernel which is defining those in [1]. The
> default "lex" and "yacc" are then used. On some systems, "yacc" is
> Berkeley Yacc. Kconfig parser files are using non-Posix Bison
> constructs.
> Attempting to generate the parser with byacc fails with error:
> yacc: e - line 97 of "zconf.y", syntax error
> %destructor {
> ^
> This patch adds the missing dependencies on host-flex and host-bison,
> and make sure the package compilation will use those, to fix this issue.
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=73a4f6dbe70a1b93c11e2d1d6ca68f3522daf434
...
> package/linux-backports/linux-backports.mk | 4 ++++
....
> +LINUX_BACKPORTS_DEPENDENCIES = host-bison host-flex
> +
> ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y)
> LINUX_BACKPORTS_KCONFIG_FILE = $(LINUX_BACKPORTS_DIR)/defconfigs/$(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG))
> else ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y)
> @@ -33,6 +35,8 @@ LINUX_BACKPORTS_KCONFIG_OPTS = $(LINUX_BACKPORTS_MAKE_OPTS)
> # LINUX_BACKPORTS_MODULE_MAKE_OPTS is used by the kernel-module infra.
> LINUX_BACKPORTS_MAKE_OPTS = \
> + LEX="$(HOST_DIR)/bin/flex" \
> + YACC="$(HOST_DIR)/bin/bison" \
Are these really in /bin? Not in /usr/bin?
Otherwise LGTM.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
next prev parent reply other threads:[~2020-11-11 21:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 16:22 [Buildroot] [PATCH 1/2] package/linux-backports: use buildroot host flex and bison Julien Olivain
2020-11-11 16:22 ` [Buildroot] [PATCH 2/2] package/linux-backports: bump version to 5.8 Julien Olivain
2020-11-11 21:47 ` Petr Vorel
2020-11-12 11:07 ` Julien Olivain
2020-11-11 21:06 ` [Buildroot] [PATCH 1/2] package/linux-backports: use buildroot host flex and bison Yann E. MORIN
2020-11-12 10:55 ` Julien Olivain
2020-11-11 21:35 ` Petr Vorel [this message]
2020-11-12 12:01 ` [Buildroot] [PATCH v2 1/2] package/linux-backports: use flex and bison to generate kconfig parser Julien Olivain
2020-11-12 12:01 ` [Buildroot] [PATCH v2 2/2] package/linux-backports: bump version to 5.8 Julien Olivain
2020-11-12 12:34 ` Baruch Siach
2020-11-12 19:30 ` Peter Seiderer
2020-11-12 21:01 ` Petr Vorel
2020-11-12 21:17 ` Yann E. MORIN
2020-11-12 21:24 ` Petr Vorel
[not found] ` <MW3PR11MB476417BF2CC5E2E72CA4AE36E9E60@MW3PR11MB4764.namprd11.prod.outlook.com>
2020-11-13 11:56 ` Julien Olivain
2020-11-12 20:53 ` [Buildroot] [PATCH v2 1/2] package/linux-backports: use flex and bison to generate kconfig parser Petr Vorel
2020-11-12 21:24 ` Yann E. MORIN
2020-11-13 13:09 ` [Buildroot] [PATCH v3 1/2] package/linux-backports: fix kernel version check Julien Olivain
2020-11-13 13:09 ` [Buildroot] [PATCH v3 2/2] package/linux-backports: bump version to 5.8 Julien Olivain
2020-11-13 19:07 ` Petr Vorel
2020-11-13 22:21 ` Yann E. MORIN
2020-11-17 21:26 ` Yann E. MORIN
2020-11-13 19:06 ` [Buildroot] [PATCH v3 1/2] package/linux-backports: fix kernel version check Petr Vorel
2020-11-13 22:08 ` Yann E. MORIN
2020-11-16 14:49 ` Peter Korsgaard
2020-11-15 15:09 ` [Buildroot] [PATCH v2 1/2] package/linux-backports: use flex and bison to generate kconfig parser Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111213505.GA28486@pevik \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox