Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/rauc: fix host build with systemd
Date: Fri, 13 Nov 2020 14:08:06 +0100	[thread overview]
Message-ID: <20201113140806.5f376fc4@windsurf.home> (raw)
In-Reply-To: <20201113122605.901352-1-b.bilas@grinn-global.com>

On Fri, 13 Nov 2020 13:26:05 +0100
Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> For some reason, autotools pkg infra doesn't pass
> DESTDIR variable to the host make env which causes
> errors during the package install step because it
> tries to install files into its own system
> instead of host directory.
> 
> That fixes the following errors:
>   /usr/bin/install -c -m 644 data/rauc.service '/usr/lib/systemd/system'
>   /usr/bin/install: cannot create regular file '/usr/lib/systemd/system/rauc.service': Permission denied
>   /usr/bin/install -c -m 644 data/de.pengutronix.rauc.conf 'no'
>   make[4]: *** [Makefile:1700: install-nodist_systemdunitDATA] Error 1
>   make[4]: *** Waiting for unfinished jobs....
> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
>  package/rauc/rauc.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
> index 61c50ab316..3cd1c85ee7 100644
> --- a/package/rauc/rauc.mk
> +++ b/package/rauc/rauc.mk
> @@ -36,6 +36,10 @@ define RAUC_INSTALL_INIT_SYSTEMD
>  		>$(TARGET_DIR)/usr/lib/systemd/system/rauc.service.d/buildroot-enable.conf  
>  endef
>  
> +HOST_RAUC_MAKE_ENV = \
> +	$(HOST_MAKE_ENV) \
> +	DESTDIR=$(STAGING_DIR)

A DESTDIR of $(STAGING_DIR) when building host-rauc doesn't seem
correct. It's an autotools package, so we're passing
--prefix=$(HOST_DIR) when building host-rauc. If that's not sufficient,
then the rauc Makefile.am should be fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-11-13 13:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 12:26 [Buildroot] [PATCH] package/rauc: fix host build with systemd Bartosz Bilas
2020-11-13 13:08 ` Thomas Petazzoni [this message]
2020-11-13 13:28   ` Bartosz Bilas
2020-11-13 13:33     ` Thomas Petazzoni
2020-11-13 13:44       ` Bartosz Bilas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113140806.5f376fc4@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox