Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/qt5/qt5coap: new package
Date: Thu, 19 Nov 2020 20:29:31 +0100	[thread overview]
Message-ID: <20201119202931.2b493b09@gmx.net> (raw)
In-Reply-To: <20201119202052.3221b62c@gmx.net>

Hello Angelo,

On Thu, 19 Nov 2020 20:20:52 +0100, Peter Seiderer <ps.report@gmx.net> wrote:

> > diff --git a/package/qt5/qt5coap/qt5coap.hash b/package/qt5/qt5coap/qt5coap.hash
> > new file mode 100644
> > index 0000000000..423278e652
> > --- /dev/null
> > +++ b/package/qt5/qt5coap/qt5coap.hash
> > @@ -0,0 +1,6 @@
> > +# Hash locally calculated
> > +sha256  f2addd89e94fb3945fc6ee6db795b0736cd3396760b31e04c01cd02558c53e07  qt5coap-5.15.1.tar.gz
> > +
> > +# Hashes for license files:
> > +sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
> > +sha256 f827ad079686ba92cc94811e35492d0e8966f704008b6da9eeda0b659fb58a8d LICENSE.FDL
>
> Preferred style is with two spaces as separators (see [1]), with this fixed
> you can add my:
>
> Reviewed-by: Peter Seiderer <ps.report@gmx.net>
>
> Regards,
> Peter
>

...and the missing reference/link:

[1] https://buildroot.org/downloads/manual/manual.html#adding-packages-hash

  The format of this file is one line for each file for which to check the hash,
  each line with the following three fields separated by two spaces.

Regards,
Peter

  reply	other threads:[~2020-11-19 19:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 10:21 [Buildroot] [PATCH 1/3] package/qt5/qt5coap: new package Angelo Compagnucci
2020-11-19 10:21 ` [Buildroot] [PATCH 2/3] package/qt5/qt5mqtt: " Angelo Compagnucci
2020-11-19 19:22   ` Peter Seiderer
2020-11-19 10:21 ` [Buildroot] [PATCH 3/3] package/qt5/qt5knx: " Angelo Compagnucci
2020-11-19 19:24   ` Peter Seiderer
2020-11-19 19:20 ` [Buildroot] [PATCH 1/3] package/qt5/qt5coap: " Peter Seiderer
2020-11-19 19:29   ` Peter Seiderer [this message]
2020-11-19 22:04     ` Angelo Compagnucci
2020-11-20 18:37       ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119202931.2b493b09@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox