Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Revert "package/gdb: prevent gdbserver being selected for RISC-V builds"
Date: Thu,  3 Dec 2020 17:45:49 -0800	[thread overview]
Message-ID: <20201204014549.2669932-1-vgupta@synopsys.com> (raw)

This reverts commit 44a9babcc67cd011e957ba9fd1cf741891957c12.

As of Buildroot 2020.11 (glibc build of qemu_riscv64_virt_defconfig),
cross-gdb for RISCV buildis fine and can also attach to a qemu
instance, so remove the gate on not building it.

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
 package/gdb/Config.in      | 3 ---
 package/gdb/Config.in.host | 1 -
 2 files changed, 4 deletions(-)

diff --git a/package/gdb/Config.in b/package/gdb/Config.in
index 48ec3e0202ac..c90d47cf0de6 100644
--- a/package/gdb/Config.in
+++ b/package/gdb/Config.in
@@ -20,8 +20,6 @@ config BR2_PACKAGE_GDB
 	depends on BR2_PACKAGE_GDB_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	depends on BR2_INSTALL_LIBSTDCPP
-	# no gdbserver on riscv
-	select BR2_PACKAGE_GDB_DEBUGGER if BR2_riscv
 	# When the external toolchain gdbserver is copied to the
 	# target, we don't allow building a separate gdbserver. The
 	# one from the external toolchain should be used.
@@ -48,7 +46,6 @@ if BR2_PACKAGE_GDB
 config BR2_PACKAGE_GDB_SERVER
 	bool "gdbserver"
 	depends on !BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY
-	depends on !BR2_riscv
 	help
 	  Build the gdbserver stub to run on the target.
 	  A full gdb is needed to debug the progam.
diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host
index 4b868e22556b..199f1c72b001 100644
--- a/package/gdb/Config.in.host
+++ b/package/gdb/Config.in.host
@@ -5,7 +5,6 @@ config BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS
 	depends on !BR2_microblaze
 	depends on !BR2_nios2
 	depends on !BR2_or1k
-	depends on !BR2_riscv
 	depends on !BR2_nds32
 
 comment "Host GDB Options"
-- 
2.25.1

             reply	other threads:[~2020-12-04  1:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  1:45 Vineet Gupta [this message]
2020-12-04  8:13 ` [Buildroot] [PATCH] Revert "package/gdb: prevent gdbserver being selected for RISC-V builds" Thomas Petazzoni
2020-12-04  8:26   ` Vineet Gupta
2020-12-04 17:15 ` Alistair Francis
2020-12-30 22:35 ` Thomas Petazzoni
2021-01-05  2:35   ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201204014549.2669932-1-vgupta@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox