Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/sysklogd: bump to version 2.1.2
Date: Wed, 9 Dec 2020 09:11:17 +0100	[thread overview]
Message-ID: <20201209091117.39ab9a0a@windsurf.home> (raw)
In-Reply-To: <CANabuZeh=hZ6sUdq-2NOnt7AnS70bmb=ZQkxemFKuHc3-AtiyA@mail.gmail.com>

Hello,

On Tue, 8 Dec 2020 21:41:27 +0100
Andreas Hilse <andreas.hilse@googlemail.com> wrote:

> Hello Thomas,
> 
> > I think the commit log should mention that the license has changed,
> > with a link to https://github.com/troglobit/sysklogd/releases/tag/v2.1.  
> Will do when I find out how to update the patch (have to read doc again).

git commit --amend

will allow you to update the commit log of the top-most commit.

Otherwise, I suggest you to document yourself about "git interactive
rebase", this is really the key functionality to understand to be able
to prepare patch series with Git.

> > syslog.c:448:27: error: ?O_CLOEXEC? undeclared (first use in this  
> function)
> >    O_WRONLY | O_NONBLOCK | O_CLOEXEC, 0)) >= 0) {  
> This is fixable by CFLAGS="-D_GNU_SOURCE" e.g. in MAKE_OPTS.
> I contacted the sysklogd maintainer through github. Waiting on a response.

Then the particular file using O_CLOEXEC should probably #define
_GNU_SOURCE before including any header file.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-12-09  8:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 16:08 [Buildroot] [PATCH 1/1] package/sysklogd: bump to version 2.1.2 Andreas Hilse
2020-08-13  8:25 ` Thomas Petazzoni
2020-08-14  9:10   ` Andreas Hilse
2020-12-05 21:21 ` Thomas Petazzoni
2020-12-08 20:41   ` Andreas Hilse
2020-12-09  8:11     ` Thomas Petazzoni [this message]
2020-12-29 15:03     ` Andreas Hilse
2020-12-29 15:13       ` Thomas Petazzoni
2020-12-29 18:11 ` [Buildroot] [PATCH v2 " Andreas Hilse
2021-01-16 19:33   ` Joachim Wiberg
2021-01-19 21:26     ` Thomas Petazzoni
2021-01-20 10:11       ` Andreas Hilse
2021-01-20 10:38         ` Thomas Petazzoni
2021-01-21 12:41       ` Joachim Wiberg
2021-01-19 21:22   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209091117.39ab9a0a@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox