Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] support/dependencies: set cmake version min to 3.15
Date: Fri, 25 Dec 2020 16:32:32 +0100	[thread overview]
Message-ID: <20201225153232.GN3188@scaer> (raw)
In-Reply-To: <20201015054600.90183-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2020-10-15 07:46 +0200, Fabrice Fontaine spake thusly:
> quazip requires cmake 3.15 since version 1.0 and
> https://github.com/stachenov/quazip/commit/89e7c201f0215032d347eef6fc0c671a1845738b
> https://github.com/stachenov/quazip/commit/818adc82246cefffa2e8851534016cf1db349da7
> 
> The rationale for this requirement is that "default locations for the
> install(TARGETS command based on the GNUInstallDirs package were only
> added in 3.14" and "3.15 is not that much of a difference from 3.14 and
> it introduced a lot of useful UI improvements.":
> https://github.com/stachenov/quazip/issues/82
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/5d848a46109aef448ea1d1b857a500d9461dc2d9
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

I was not too keen on applying this bump, because that is going to
increas the build quite quite a bit on older distros...

However, there is not much we can do against upstream's will.
Furthermore, we can only count on more packages requiring a newer cmake
version as tiem passes, so bumping the requirement is inevitable.
I've added a note to that effect in the commit log, and applied to
master, thanks.

Regards,
Yann E. MORIN.

> ---
>  support/dependencies/check-host-cmake.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/support/dependencies/check-host-cmake.mk b/support/dependencies/check-host-cmake.mk
> index 01f38da376..e1bbcd62c8 100644
> --- a/support/dependencies/check-host-cmake.mk
> +++ b/support/dependencies/check-host-cmake.mk
> @@ -1,9 +1,9 @@
> -# Set this to either 3.10 or higher, depending on the highest minimum
> +# Set this to either 3.15 or higher, depending on the highest minimum
>  # version required by any of the packages bundled in Buildroot. If a
>  # package is bumped or a new one added, and it requires a higher
>  # version, our cmake infra will catch it and build its own.
>  #
> -BR2_CMAKE_VERSION_MIN = 3.10
> +BR2_CMAKE_VERSION_MIN = 3.15
>  
>  BR2_CMAKE_CANDIDATES ?= cmake cmake3
>  BR2_CMAKE ?= $(call suitable-host-package,cmake,\
> -- 
> 2.28.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-12-25 15:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  5:46 [Buildroot] [PATCH 1/1] support/dependencies: set cmake version min to 3.15 Fabrice Fontaine
2020-12-25 15:32 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201225153232.GN3188@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox