From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/rt-tests: add support to build without numactl
Date: Sun, 27 Dec 2020 21:04:04 +0100 [thread overview]
Message-ID: <20201227210404.4b602523@windsurf.home> (raw)
In-Reply-To: <20201227191349.GA18184@arbad>
Hello,
On Sun, 27 Dec 2020 20:13:50 +0100
Andreas Klinger <ak@it-klinger.de> wrote:
> - select BR2_PACKAGE_NUMACTL
> + select BR2_PACKAGE_NUMACTL if BR2_PACKAGE_NUMACTL_ARCH_SUPPORTS
In fact, I disagree with Baruch: if numactl is an optional dependency,
it really should be optional. So this line in Config.in would not be
needed.
> +ifeq ($(BR2_PACKAGE_NUMACTL_ARCH_SUPPORTS),y)
And change this to:
ifeq ($(BR2_PACKAGE_NUMACTL),y)
> RT_TESTS_DEPENDENCIES = numactl
> +else
> +RT_TESTS_MAKE_OPTS += NUMA=0
> +endif
This way, numactl is only used by rt-tests if numactl is enabled.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-12-27 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 19:13 [Buildroot] [PATCH v3] package/rt-tests: add support to build without numactl Andreas Klinger
2020-12-27 20:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201227210404.4b602523@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox